Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:include-macros missing key? #29

Open
NoahTheDuke opened this issue Oct 17, 2024 · 2 comments
Open

:include-macros missing key? #29

NoahTheDuke opened this issue Oct 17, 2024 · 2 comments

Comments

@NoahTheDuke
Copy link

I trust that the code currently works, but should the runtime-cljs line say :include-macros true? The clojurescript compiler's spec expects only true: https://github.com/clojure/clojurescript/blob/f1fc819da94147411e353ecb17c751af6a18ce2e/src/main/cljs/cljs/core/specs/alpha.cljc#L130

runtime-cljs "[lread.test-doc-blocks.runtime :include-macros]"

@lread
Copy link
Owner

lread commented Oct 17, 2024

Thanks for the issue @NoahTheDuke!
I haven't looked at this code in a long long while.
I'll push this on my todo list to have a peek.
Are you having a specific issue or is this just a lil' something you happened to notice?

@NoahTheDuke
Copy link
Author

Just something I happened to notice when reading the generated test files. like I said above, I trust that this already works cuz no one's commented on it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants