fix: mark primary key auto-increment only if column type is INT #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhmlau
reviewed
Jun 28, 2024
lib/migration.js
Outdated
| @@ -628,7 +628,8 @@ function mixinMigration(MySQL, mysql) { | |||
| if (pks.length === 1) { | |||
| const idName = this.idName(model); | |||
| const idProp = this.getModelDefinition(model).properties[idName]; | |||
| if (idProp.generated) { | |||
| const idColumnType = this.columnDataType(model, idName); | |||
| if (idProp.generated && idColumnType === 'INT') { | |||
There was a problem hiding this comment.
I believe there are other integer type that supports auto increment in mysql, according to this docs: https://dev.mysql.com/doc/refman/8.4/en/example-auto-increment.html#:~:text=Use%20the%20smallest%20integer%20data,to%20allow%20a%20greater%20range.
There was a problem hiding this comment.
You are right @dhmlau. The other integer types also support autoincrement. I have updated the PR. Please have a look at the PR now.
Thanks for the review.
aaqilniz
force-pushed
the
fix/column-type-generated
branch
3 times, most recently
from
7a7b7c4
to
6087628
Compare
…MALLINT MEDIUMINT INT BIGINT Signed-off-by: Muhammad Aaqil <[email protected]>
aaqilniz
force-pushed
the
fix/column-type-generated
branch
from
6087628
to
c9e80ab
Compare
dhmlau
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR marks an id property autoincrement only when type of the id property is integer/number.
Checklist
npm testpasses on your machine