v7.0.0-alpha.1 - MongoInvalidArgumentError: Argument "options" must not be function

[lien-dkseo]

Steps to reproduce

const cursor = (await this.studyRepository.execute(
  'Study',
  'aggregate',
  [
    {
      $facet: {
        StudyCount: ...,
        SampleTypeCount: ...,
      },
    },
  ],
)) as AggregationCursor;

Current Behavior

MongoInvalidArgumentError: Argument "options" must not be function
    at Collection.aggregate (d:\dev\lien\samplebox-web-backend\node_modules\loopback-connector-mongodb\node_modules\mongodb\lib\collection.js:371:19)
    at d:\dev\lien\samplebox-web-backend\node_modules\loopback-connector-mongodb\lib\mongodb.js:602:38

Expected Behavior

working code in 6.2.0

Link to reproduction sandbox

Additional information

win32 x64 18.15.0

├── @loopback/[email protected]
├── @loopback/[email protected]
├── @loopback/[email protected]
├── @loopback/[email protected]
├── @loopback/[email protected]
├── @loopback/[email protected]
├── @loopback/[email protected]
├── @loopback/[email protected]
├── @loopback/[email protected]
├── [email protected]
├── [email protected]

Related Issues

See Reporting Issues for more tips on writing good issues

[achrinza]

MongoDB v5 dropped support for the already-deprecated callback-style approach in favour of async/await: mongodb/node-mongodb-native#3499

Offending line is the use of a callback for a Juggler observer:

loopback-connector-mongodb/lib/mongodb.js

Lines 600 to 602 in 21a25fe

	args[args.length - 1] = observerCallback;
	debug('MongoDB: model=%s command=%s', modelName, command, args);
	return collection[command].apply(collection, args);

AFAIK, Juggler v4 already supports async/await. Hence this should be a straightforward fix.