Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlutterSliderTooltip disableAnimation and alwaysShowTooltip odd #35

Open
large opened this issue Apr 7, 2024 · 1 comment
Open

FlutterSliderTooltip disableAnimation and alwaysShowTooltip odd #35

large opened this issue Apr 7, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@large
Copy link

large commented Apr 7, 2024

Hi, I tested your xlider and have some odd issues when setting disableAnimation and alwaysShowTooltip:

First, if the tooltip is like this

          tooltip: FlutterSliderTooltip(
            disableAnimation: true,
            alwaysShowTooltip: false,
            direction: FlutterSliderTooltipDirection.right,
          ),

The tooltip will animate from top to right.
If you set FlutterSliderTooltipDirection.top it will popup on top as expected.

Second, when tooltip is like this

          tooltip: FlutterSliderTooltip(
            disableAnimation: true,
            alwaysShowTooltip: true,
            direction: FlutterSliderTooltipDirection.right,
          ),

Tooltip will always show on top, and the FlutterSliderTooltipDirection.left/top/right has little to no effect
image

Third, when tooltip is like this

          tooltip: FlutterSliderTooltip(
            disableAnimation: false,
            alwaysShowTooltip: true,
            direction: FlutterSliderTooltipDirection.right,
          ),

The tooltip are actually behind the knob
image

Is this by design or is it buggy?

@loonix
Copy link
Owner

loonix commented Apr 8, 2024

Hi @large, thanks for your report. I think this is per design from the previous project owner. If you ever fix it please feel free to make a PR I will gladly merge it

@loonix loonix added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Apr 8, 2024
@loonix loonix added this to the 3.1.0 milestone Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants