chore: add release-please and publishing metrics collection #6
Conversation
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| name: release-please | ||
| jobs: | ||
| release-please: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: google-github-actions/release-please-action@v2 | ||
| with: | ||
| command: manifest | ||
| token: ${{ secrets.LOS_AUTO_BOT_RP_TOKEN }} |
There was a problem hiding this comment.
copy/paste from sdk-codegen: enable the release-please action. note: there are a few different ways to configure release-please but I think that as a GH Action using the input command: manifest + a config and .manifest file is the most robust way
we should enable the "semantic pull requests" app/check on this repo to enforce conventional commit formatted commit messages (which release-please relies on for knowing how to bump versions)
There was a problem hiding this comment.
todo: for this and publish-metrics.yml we'll have to add this repo for access to the relevant org GitHub secrets
todo: I think we should only enable the "squash merge" setting (components and sdk-codegen have it, I think it should be our standard)
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "packages": { | |||
| ".": {} | |||
There was a problem hiding this comment.
keys under "packages" are paths that are parent directories to a child package. the "." path is the root path which is the only one in this non-mono-repo. see https://github.com/googleapis/release-please/blob/master/docs/manifest-releaser.md#configfile for a full config file rundown (I don't think we need anything else)
| @@ -0,0 +1,5 @@ | |||
| { | |||
There was a problem hiding this comment.
| { | |
| { | |
| "bootstrap-sha": "fc9873ed5e1baf428b6cb62c8af99b3ad8957c8a", |
oops, forgot this. I means release-please will ignore any prior commits. It's a one-time setting that is ignored after the first Release PR is merged and can be safely removed at that point.
|
I think the failure is a flaky test, I need to improve the consistency of them. I'll take a peek a bit later. Thank you for setting this up! |
No description provided.