Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bqjdbc URL/connection builder test utility #190

Open
goomrw opened this issue Jan 4, 2024 · 0 comments
Open

Add bqjdbc URL/connection builder test utility #190

goomrw opened this issue Jan 4, 2024 · 0 comments

Comments

@goomrw
Copy link
Contributor

goomrw commented Jan 4, 2024

bqjdbc connections are configured via URL parameters.
Tests configure their connections with string literals which is very error prone (what if a parameter is listed twice? what if there are two &?)

We should write a utility class that constructs URLs at a higher level to eliminate these issues. We might consider a ConnectionBuilder to manage the creation of connections.

See:

          maybe there should be a ConnectionBuilder that removes all this JDBC Url crap from our own tests ?

Seems like an obvious way to cause bugs.

Originally posted by @fzakaria in #186 (comment)

@goomrw goomrw changed the title Add bqjdbc URL/Connection builder test utility Add bqjdbc URL/connection builder test utility Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant