Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebAssemply target fails compile #2306

Closed
jwrober opened this issue Jun 25, 2024 · 2 comments · Fixed by #2418
Closed

WebAssemply target fails compile #2306

jwrober opened this issue Jun 25, 2024 · 2 comments · Fixed by #2418
Labels
bug Something isn't working

Comments

@jwrober
Copy link
Collaborator

jwrober commented Jun 25, 2024

Describe the bug
The WebAssemply target won't compile during weekly builds

In file included from /home/runner/work/freeciv21/freeciv21/common/scriptcore/api_common_intl.cpp:17:
In file included from /home/runner/work/freeciv21/freeciv21/common/scriptcore/api_common_intl.h:13:
/home/runner/work/freeciv21/freeciv21/dependencies/sol2/sol/sol.hpp:6755:10: error: no member named 'construct' in 'optional<type-parameter-0-0 &>'
 6755 |                         this->construct(std::forward<Args>(args)...);
      |                         ~~~~  ^
/home/runner/work/freeciv21/freeciv21/dependencies/sol2/sol/sol.hpp:14541:32: warning: unknown warning group '-Wmaybe-uninitialized', ignored [-Wunknown-warning-option]
 14541 | #pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
       |                                ^
/home/runner/work/freeciv21/freeciv21/dependencies/sol2/sol/sol.hpp:17294:32: warning: unknown warning group '-Wmaybe-uninitialized', ignored [-Wunknown-warning-option]
 17294 | #pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
       |                                ^
2 warnings and 1 error generated.
make[2]: *** [common/scriptcore/CMakeFiles/scriptcore.dir/build.make:107: common/scriptcore/CMakeFiles/scriptcore.dir/api_common_intl.cpp.o] Error 1
make[2]: Leaving directory '/home/runner/work/freeciv21/freeciv21'
make[1]: *** [CMakeFiles/Makefile2:4757: common/scriptcore/CMakeFiles/scriptcore.dir/all] Error 2
make[1]: Leaving directory '/home/runner/work/freeciv21/freeciv21'
make: *** [Makefile:156: all] Error 2
emmake: error: 'make' failed (returned 2)
Error: Process completed with exit code 1.

Suggestion is to update Sol and the version of Emscripten we are using.

@jwrober jwrober added bug Something isn't working Untriaged This issue or PR needs triaging labels Jun 25, 2024
@jwrober
Copy link
Collaborator Author

jwrober commented Jun 28, 2024

We are using the current version of Sol2

@lmoureaux
Copy link
Contributor

ThePhD/sol2#1617

@lmoureaux lmoureaux removed the Untriaged This issue or PR needs triaging label Sep 2, 2024
jwrober added a commit to jwrober/freeciv21 that referenced this issue Oct 26, 2024
jwrober added a commit that referenced this issue Oct 26, 2024
lmoureaux pushed a commit that referenced this issue Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants