Skip to content

Commit fb63946

Browse files
committed
Drop jquery.
1 parent 0d6e9ad commit fb63946

File tree

12 files changed

+343
-246
lines changed

12 files changed

+343
-246
lines changed

.eslintrc.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"parserOptions": { "sourceType": "module", "ecmaVersion": 2022 },
55
"overrides": [
66
{
7-
"files": ["src/js/*.js"],
7+
"files": ["src/js/*.mjs"],
88
"extends": ["eslint:recommended", "prettier"],
99
"parserOptions": {
1010
"project": ["./tsconfig.json"]

dist/js/lightbox.cjs

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

dist/js/lightbox.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/js/lightbox.mjs

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

examples/index.html

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -85,11 +85,6 @@ <h3>A Four Image Set</h3>
8585
>
8686
</p>
8787
</section>
88-
<script
89-
src="https://code.jquery.com/jquery-3.6.1.min.js"
90-
integrity="sha256-o88AwQnZB+VDvE9tvIXrMQaPlFFSUTR+nldQm1LuPXQ="
91-
crossorigin="anonymous"
92-
></script>
9388
<script defer src="../dist/js/lightbox.js"></script>
9489
</body>
9590
</html>

package.json

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,16 @@
2121
},
2222
"exports": {
2323
".": {
24-
"import": "./dist/js/lightbox.mjs",
25-
"require": "./dist/js/lightbox.cjs",
24+
"node": {
25+
"import": "./dist/js/lightbox.mjs",
26+
"require": "./dist/js/lightbox.cjs",
27+
"default": "./dist/js/lightbox.js"
28+
},
29+
"browser": {
30+
"import": "./dist/js/lightbox.mjs",
31+
"require": "./dist/js/lightbox.cjs",
32+
"default": "./dist/js/lightbox.js"
33+
},
2634
"default": "./dist/js/lightbox.js"
2735
},
2836
"./css": "./dist/css/*.css",
@@ -57,7 +65,7 @@
5765
"format:js": "prettier --write src/ts",
5866
"lint": "run-p lint:*",
5967
"lint:css": "stylelint src/css/lightbox.css",
60-
"lint:js": "eslint src/js/*.js",
68+
"lint:js": "eslint src/js/*.mjs",
6169
"prebuild:js": "npm run clean:js",
6270
"watch": "run-p watch:*",
6371
"watch:css": "npm run build:css -- -w",
@@ -83,9 +91,6 @@
8391
"stylelint-config-recess-order": "^3.0.0",
8492
"stylelint-config-standard": "^26.0.0"
8593
},
86-
"peerDependencies": {
87-
"jquery": "^3.0.0"
88-
},
8994
"browserslist": [
9095
"> 1% and last 2 versions",
9196
"not dead"

scripts/build.mjs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ const errors = [];
2121
for (const result of results) {
2222
if (result.status === 'rejected') {
2323
errors.push(result.reason);
24-
continue;
2524
} else if (result.value.errors.length > 0) {
2625
errors.push(...result.value.errors);
2726
}

scripts/config.mjs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,8 @@ const browserslistPlugin = esbuildPluginBrowserslist(browserslist(), {
1010

1111
/** @type {BuildOptions} */
1212
export const commonConfig = {
13-
entryPoints: ['src/js/lightbox.js'],
1413
outbase: 'src/js',
15-
bundle: false,
14+
bundle: true,
1615
banner: {
1716
js: `/*!
1817
* Lightbox v2.11.2
@@ -32,13 +31,15 @@ export const commonConfig = {
3231

3332
/** @type {BuildOptions} */
3433
export const esmConfig = {
34+
entryPoints: ['src/js/lightbox.mjs'],
3535
format: 'esm',
3636
outfile: 'dist/js/lightbox.mjs',
3737
plugins: [browserslistPlugin]
3838
};
3939

4040
/** @type {BuildOptions} */
4141
export const cjsConfig = {
42+
entryPoints: ['src/js/lightbox.cjs'],
4243
format: 'cjs',
4344
platform: 'node',
4445
outfile: 'dist/js/lightbox.cjs',
@@ -47,9 +48,9 @@ export const cjsConfig = {
4748

4849
/** @type {BuildOptions} */
4950
export const browserConfig = {
51+
entryPoints: ['src/js/browser.mjs'],
5052
format: 'iife',
5153
platform: 'browser',
52-
globalName: 'lightbox',
5354
outfile: 'dist/js/lightbox.js',
5455
plugins: [browserslistPlugin]
5556
};

scripts/serve.mjs

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,13 @@
11
import esbuild from 'esbuild';
22
import {
33
commonConfig,
4-
esmConfig,
5-
cjsConfig,
64
browserConfig,
75
serveConfig,
86
serveOptions
97
} from './config.mjs';
108

11-
const config = { ...commonConfig, ...serveConfig };
12-
13-
await Promise.all([
14-
esbuild.serve(serveOptions, { ...config, ...esmConfig }),
15-
esbuild.serve(serveOptions, { ...config, ...cjsConfig }),
16-
esbuild.serve(serveOptions, { ...config, ...browserConfig })
17-
]);
9+
await esbuild.serve(serveOptions, {
10+
...commonConfig,
11+
...serveConfig,
12+
...browserConfig
13+
});

src/js/browser.mjs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
import lightbox from './lightbox.mjs';
2+
window.lightbox = lightbox;

0 commit comments

Comments
 (0)