Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to retry on unknown exceptions #115

Open
borissnd opened this issue Sep 24, 2020 · 3 comments
Open

Add ability to retry on unknown exceptions #115

borissnd opened this issue Sep 24, 2020 · 3 comments
Assignees

Comments

@borissnd
Copy link

Logstash drops batches of logs when it encounters connection resets or read time outs.

Manticore retryable exceptions are hardcoded in the plugin. Log sending is not retried on all other Manticore exceptions.
Retryable error codes parameter does not help in this case, because these types of errors are raised as exceptions.

The plugin should allow the consumer to configure whether it would retry on unknown (or unmapped) exceptions.

Examples:
:headers=>{"Content-Type"=>"application/json", "Content-Encoding"=>"gzip"}, :message=>"Read timed out", :class=>"Manticore::UnknownException", :backtrace=>["/usr/share/logstash/vendor/bundle/jruby/2.5.0/gems/manticore-0.6.4-java/lib/manticore/response.rb:37:in block in initialize'", "/usr/share/logstash/vendor/bundle/jruby/2.5.0/gems/manticore-0.6.4-java/lib/manticore/response.rb:79:in call'", "/usr/share/logstash/vendor/bundle/jruby/2.5.0/gems/logstash-output-http-5.2.4/lib/logstash/outputs/http.rb:239:in send_event'", "/usr/share/logstash/vendor/bundle/jruby/2.5.0/gems/logstash-output-http-5.2.4/lib/logstash/outputs/http.rb:175:in send_events'", "/usr/share/logstash/vendor/bundle/jruby/2.5.0/gems/logstash-output-http-5.2.4/lib/logstash/outputs/http.rb:124:in multi_receive'", "org/logstash/config/ir/compiler/OutputStrategyExt.java:118:in multi_receive'", "org/logstash/config/ir/compiler/AbstractOutputDelegatorExt.java:101:in multi_receive'", "/usr/share/logstash/logstash-core/lib/logstash/java_pipeline.rb:243:in block in start_workers'"], :will_retry=>false}

[HTTP Output Failure] Could not fetch URL {:url=>"https://smartcollector.command.cysiv.com/logs", :method=>:post, :headers=>{"Content-Type"=>"application/json", "Content-Encoding"=>"gzip"}, :message=>"Connection reset", :class=>"Manticore::UnknownException", :backtrace=>["/usr/share/logstash/vendor/bundle/jruby/2.5.0/gems/manticore-0.6.4-java/lib/manticore/response.rb:37:in block in initialize'", "/usr/share/logstash/vendor/bundle/jruby/2.5.0/gems/manticore-0.6.4-java/lib/manticore/response.rb:79:in call'", "/usr/share/logstash/vendor/bundle/jruby/2.5.0/gems/logstash-output-http-5.2.4/lib/logstash/outputs/http.rb:239:in send_event'", "/usr/share/logstash/vendor/bundle/jruby/2.5.0/gems/logstash-output-http-5.2.4/lib/logstash/outputs/http.rb:175:in send_events'", "/usr/share/logstash/vendor/bundle/jruby/2.5.0/gems/logstash-output-http-5.2.4/lib/logstash/outputs/http.rb:124:in multi_receive'", "org/logstash/config/ir/compiler/OutputStrategyExt.java:118:in multi_receive'", "org/logstash/config/ir/compiler/AbstractOutputDelegatorExt.java:101:in multi_receive'", "/usr/share/logstash/logstash-core/lib/logstash/java_pipeline.rb:243:in block in start_workers'"], :will_retry=>false}

@borissnd borissnd changed the title Add ability to retry unknown exceptions Add ability to retry on unknown exceptions Sep 24, 2020
@parkertim
Copy link

Any update from dev on this issue? I am running into this problem a lot as well where my log messages aren't being retried when I get "Connection reset" errors. This is a problem that needs to be resolved so a user can decide if it should retry or not.

@robbavey robbavey self-assigned this Jan 28, 2022
@mpreddy77
Copy link

@robbavey any update on this issue? Its affecting a majority of our integrations between Logstash and ES in V7.17.5. Any workaround to trap this case would be mighty helpful. Cheers!

@tszming
Copy link

tszming commented Feb 21, 2023

@mpreddy77 connection reset issue is addressed in #127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants