Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong hash format used in examples for proxy option #47

Open
arminru opened this issue Nov 20, 2024 · 0 comments
Open

Wrong hash format used in examples for proxy option #47

arminru opened this issue Nov 20, 2024 · 0 comments

Comments

@arminru
Copy link

arminru commented Nov 20, 2024

Description:

The HTTP mixin docs use commas as delimiters between entries for the hash used in the proxy config option examples. As per the Logstash config file format documented in https://www.elastic.co/guide/en/logstash/current/configuration-file-structure.html#hash, these would need to be space delimited instead.
Also the plain string the first example would need to be put into quotation marks (proxy => 'http://proxy.org:1234'), I believe.

URL:

# 1. Proxy host in form: http://proxy.org:1234
# 2. Proxy host in form: {host => "proxy.org", port => 80, scheme => 'http', user => 'username@host', password => 'password'}
# 3. Proxy host in form: {url => 'http://proxy.org:1234', user => 'username@host', password => 'password'}

Proposed change:

Current:

# 1. Proxy host in form: http://proxy.org:1234
# 2. Proxy host in form: {host => "proxy.org", port => 80, scheme => 'http', user => 'username@host', password => 'password'}
# 3. Proxy host in form: {url =>  'http://proxy.org:1234', user => 'username@host', password => 'password'

Expected:

# 1. Proxy host in form: 'http://proxy.org:1234'
# 2. Proxy host in form: {host => "proxy.org" port => 80 scheme => 'http' user => 'username@host' password => 'password'}
# 3. Proxy host in form: {url =>  'http://proxy.org:1234' user => 'username@host' password => 'password'}

Anything else?

See also: logstash-plugins/logstash-output-http#148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant