Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use different approach for converting extension fields that have an array-like syntax #72

Open
n0othing opened this issue Sep 9, 2019 · 0 comments

Comments

@n0othing
Copy link

n0othing commented Sep 9, 2019

The current approach [1][2] to converting extension fields that have an array-like syntax (e.g changing fieldname[0] to [fieldname][0]) can lead to conflicts or data loss if a key with the same fieldname exists elsewhere in the event.

To decrease the risk of conflicts or data loss, the resulting converted key could use a different syntax that increases the likelihood of being unique (e.g fieldname__0)

[1] https://github.com/logstash-plugins/logstash-codec-cef/blob/master/lib/logstash/codecs/cef.rb#L200-L204
[2] https://github.com/logstash-plugins/logstash-codec-cef/blob/master/lib/logstash/codecs/cef.rb#L296-L297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant