Skip to content

PSR-2 #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rtheunissen opened this issue May 5, 2015 · 4 comments
Closed

PSR-2 #23

rtheunissen opened this issue May 5, 2015 · 4 comments
Assignees
Milestone

Comments

@rtheunissen
Copy link

Would you consider changing to PSR-2? While working on the pull request for #21 I couldn't help but notice gross indentation inconsistencies and I believe that this project would benefit greatly from following a framework standard such as PSR-2 (as it already applies PSR-4).

A few obvious things that would need to be updated are:

  • Tabs to spaces
  • No new line after control structures
  • New line after class declaration
@logical-and
Copy link
Owner

Well, sounds like good idea. I will take a care about coding standard soon.
Thank you :)

@logical-and logical-and self-assigned this May 5, 2015
@logical-and logical-and added this to the 0.7 milestone May 5, 2015
@rtheunissen
Copy link
Author

I will take a care about coding standard soon.

I'd be happy to do it and create a pull request?

@logical-and
Copy link
Owner

Yes, it will be a great help for us all, if you do it. :)
If you working in PHPStorm, then you can use PSR-1/PSR-2 from predefined styles, and apply that style to all files.

@logical-and
Copy link
Owner

@rtheunissen Please look on updated code, is it the fresh psr-2? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants