fix(cli): consider sleeping workspace as ready, will automatically be woken up when connecting

pascalbreuninger · pascalbreuninger · commit 9f518afaa29f · 2024-06-28T18:14:28.000+02:00
diff --git a/cmd/pro/provider/up.go b/cmd/pro/provider/up.go
@@ -335,6 +335,11 @@ func getParametersFromEnvironment(ctx context.Context, kubeClient kube.Interface
 }
 
 func isReady(workspace *managementv1.DevPodWorkspaceInstance) bool {
+	// Sleeping is considered ready in this context. The workspace will be woken up as soon as we connect to it
+	if workspace.Status.Phase == storagev1.InstanceSleeping {
+		return true
+	}
+
 	return workspace.Status.Phase == storagev1.InstanceReady
 }
 

Original file line number	Diff line number	Diff line change
`@@ -335,6 +335,11 @@ func getParametersFromEnvironment(ctx context.Context, kubeClient kube.Interface`
`335`	`335`	`}`
`336`	`336`
`337`	`337`	`func isReady(workspace *managementv1.DevPodWorkspaceInstance) bool {`
	`338`	`+ // Sleeping is considered ready in this context. The workspace will be woken up as soon as we connect to it`
	`339`	`+ if workspace.Status.Phase == storagev1.InstanceSleeping {`
	`340`	`+ return true`
	`341`	`+ }`
	`342`	`+`
`338`	`343`	`return workspace.Status.Phase == storagev1.InstanceReady`
`339`	`344`	`}`
`340`	`345`