Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up detach_maybe and data_maybe uses throughout the library #3

Open
bamos opened this issue Oct 14, 2018 · 0 comments
Open

Clean up detach_maybe and data_maybe uses throughout the library #3

bamos opened this issue Oct 14, 2018 · 0 comments

Comments

@bamos
Copy link
Member

bamos commented Oct 14, 2018

I also don't like having the x.requires_grad conditional in detach_maybe since it hides if that tensor is detached or not.

\cc @ivandariojr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bamos