Update S3LayerDeleter to consider AWS SDK request limit

[zacdezgeo]

Overview

Very straightforward fix to deal with the delete request limit of the AWS SDK.

Simply chunks the objectIdentifiers list into lists of length smaller than the requestLimit and iteratively makes the delete call to the AWS SDK.

Checklist

• ./CHANGELOG.md updated, if necessary. Link to the issue if closed, otherwise the PR.
• Module Hierarchy updated, if necessary
• docs guides update, if necessary
• New user API has useful Scaladoc strings

Demo

TODO

Notes

Unsure of the testing strategies favored for S3 and if the changes should be included in the changelog.

Closes #3371

[pomadchin]

Thank you so much for your (first) contribution! 🎉 🎉 🎉 🎉 I left just a couple of comments to move limit into the API and cleanup the code.

One more thing! Could you sign ECA please to make Eclipse license checker happy?

(Eclipse grabs your name and email from the commit, so doublecheck that you commited under the correct email (that was used to sign ECA), right now the ECA is required for thezachary[at]****.io email).

[zacdezgeo]

Wondering if we should be returning the status or even the unsuccessfully deleted objects of the s3Client.deleteObjects request. Something like in the AWS's documentation.

DeleteObjectsResult delObjRes = s3Client.deleteObjects(multiObjectDeleteRequest);
int successfulDeletes = delObjRes.getDeletedObjects().size();

[pomadchin]

Nice! 🎉 ECA looks good as well.

Could you move that consturctor overload into the companion object?

[pomadchin]

@zacharyDez that's a good move, however, it requires a separate issue I guess. We have LayerDeleters for our other backends so the error encoding should be synchronized with all of them. I agree that it could be a very nice improvement 👍

@zacharyDez would you mind creating an issue to track down this idea?

[zacdezgeo]

Opened the new issue #3373 @pomadchin

[pomadchin]

LGTM! Merging once CI is green 🎉

And thanks for filing the follow up issue!

[zacdezgeo]

Thanks for your feedback with the PR! 🙏