Conform to the newer Ruff rules, and use the LocalStack defaults (#163)

Author: purcell

.github/workflows/wiremock.yml

@@ -51,7 +51,7 @@ jobs:
           docker pull "$IMAGE_NAME"
           docker pull wiremock/wiremock
           docker pull public.ecr.aws/lambda/python:3.12
-          pip install localstack terraform-local awscli-local[ver1]
+          pip install localstack terraform-local awscli-local
 
           make install
           make lint

keycloak/localstack_keycloak/extension.py

@@ -9,7 +9,10 @@
 from localstack_extensions.utils.docker import ProxiedDockerContainerExtension
 
 from .utils import (
+    DEFAULT_AUDIENCE,
     DEFAULT_CLIENT_SECRET,
+    DEFAULT_REALM,
+    DEFAULT_VERSION,
     ENV_KEYCLOAK_DEFAULT_PASSWORD,
     ENV_KEYCLOAK_DEFAULT_USER,
     ENV_KEYCLOAK_FLAGS,
@@ -19,9 +22,6 @@
     ENV_KEYCLOAK_VERSION,
     KEYCLOAK_HTTP_PORT,
     KEYCLOAK_MGMT_PORT,
-    DEFAULT_AUDIENCE,
-    DEFAULT_REALM,
-    DEFAULT_VERSION,
     get_default_client_config,
     get_default_realm_config,
     get_env,

keycloak/sample-app/cdk/stacks/api_stack.py

@@ -1,14 +1,20 @@
+import os
+
 from aws_cdk import (
-    Stack,
     Duration,
-    aws_lambda as lambda_,
+    RemovalPolicy,
+    Stack,
+)
+from aws_cdk import (
     aws_apigateway as apigw,
+)
+from aws_cdk import (
     aws_dynamodb as dynamodb,
-    aws_iam as iam,
-    RemovalPolicy,
+)
+from aws_cdk import (
+    aws_lambda as lambda_,
 )
 from constructs import Construct
-import os
 
 
 class KeycloakSampleApiStack(Stack):

keycloak/sample-app/lambda/authorizer/handler.py

@@ -10,8 +10,6 @@
 """
 
 import base64
-import hashlib
-import hmac
 import json
 import os
 import urllib.request

keycloak/tests/test_extension.py

@@ -1,12 +1,12 @@
-import json
 import base64
+import json
 import time
+
+import boto3
 import pytest
 import requests
-import boto3
 from botocore.config import Config
 
-
 LOCALSTACK_URL = "http://localhost:4566"
 KEYCLOAK_URL = "http://keycloak.localhost.localstack.cloud:4566"
 KEYCLOAK_DIRECT_URL = "http://localhost:8080"  # Direct access to Keycloak HTTP port
@@ -189,7 +189,7 @@ class TestUserManagement:
 
     def test_create_user_with_required_profile_fields(self, admin_token):
         """Verify user creation works with required Keycloak 26+ profile fields.
-        
+
         Keycloak 26+ requires email, firstName, lastName for users to be "fully set up".
         Password must be set separately via reset-password endpoint.
         """
@@ -302,7 +302,10 @@ def test_incomplete_user_fails_password_grant(self, admin_token):
             timeout=30,
         )
         assert token_response.status_code != 200
-        assert "not fully set up" in token_response.json().get("error_description", "").lower()
+        assert (
+            "not fully set up"
+            in token_response.json().get("error_description", "").lower()
+        )
 
         # Cleanup
         requests.delete(f"{users_url}/{user_id}", headers=headers, timeout=10)

paradedb/README.md

@@ -31,7 +31,7 @@ conn = psycopg2.connect(
     port=5432,
     database="mydatabase",
     user="myuser",
-    password="mypassword"
+    password="mypassword",
 )
 ```
 

paradedb/localstack_paradedb/extension.py

@@ -1,8 +1,8 @@
 import os
 import socket
 
-from localstack_extensions.utils.docker import ProxiedDockerContainerExtension
 from localstack import config
+from localstack_extensions.utils.docker import ProxiedDockerContainerExtension
 
 # Environment variables for configuration
 ENV_POSTGRES_USER = "PARADEDB_POSTGRES_USER"
@@ -88,7 +88,7 @@ def _check_tcp_port(self, host: str, port: int, timeout: float = 2.0) -> None:
         try:
             sock.connect((host, port))
             sock.close()
-        except (socket.timeout, socket.error) as e:
+        except (TimeoutError, OSError) as e:
             raise AssertionError(f"Port {port} not ready: {e}")
 
     def get_connection_info(self) -> dict:

paradedb/tests/test_extension.py

@@ -3,7 +3,6 @@
 from localstack.utils.strings import short_uid
 from localstack.utils.sync import retry
 
-
 # Connection details for ParadeDB
 # Connect through LocalStack gateway with TCP proxying
 HOST = "paradedb.localhost.localstack.cloud"
@@ -15,6 +14,7 @@
 
 def get_connection():
     """Create a connection to ParadeDB, retrying until the server is ready."""
+
     def _connect():
         return psycopg2.connect(
             host=HOST,
@@ -23,6 +23,7 @@ def _connect():
             password=PASSWORD,
             database=DATABASE,
         )
+
     return retry(_connect, retries=15, sleep=2.0)
 
 

ruff.toml

@@ -0,0 +1,18 @@
+[lint]
+ignore = [
+    "B006", # TODO Do not use mutable data structures for argument defaults
+    "B007", # TODO Loop control variable x not used within loop body
+    "B017", # TODO `pytest.raises(Exception)` should be considered evil
+    "B019", # TODO Use of `functools.lru_cache` or `functools.cache` on methods can lead to memory leaks
+    "B023", # TODO Function definition does not bind loop variable `server`
+    "B024", # TODO x is an abstract base class, but it has no abstract methods
+    "B026", # TODO Star-arg unpacking after a keyword argument is strongly discouraged
+    "B027", # TODO `Server.do_shutdown` is an empty method in an abstract base class, but has no abstract decorator
+    "B904", # TODO Within an `except` clause, raise exceptions with `raise ... from err` or `raise ... from None` to distinguish them from errors in exception handling
+    "C901", # TODO function is too complex
+    "E402", # TODO Module level import not at top of file
+    "E501", # E501 Line too long - handled by black, see https://docs.astral.sh/ruff/faq/#is-ruff-compatible-with-black
+    "E741", # TODO Ambiguous variable name: `l`
+    "T201", # TODO `print` found
+]
+select = ["B", "C", "E", "F", "I", "W", "T", "B9", "G", "UP", "TID251"]

typedb/tests/test_extension.py

@@ -1,7 +1,13 @@
-import requests
 import httpx
+import requests
 from localstack.utils.strings import short_uid
-from typedb.driver import TypeDB, Credentials, DriverOptions, TransactionType, DriverTlsConfig
+from typedb.driver import (
+    Credentials,
+    DriverOptions,
+    DriverTlsConfig,
+    TransactionType,
+    TypeDB,
+)
 
 
 def test_connect_to_db_via_http_api():