Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Periodic reruns #10

Open
MichaelAntonFischer opened this issue Sep 18, 2023 · 6 comments
Open

Feature request: Periodic reruns #10

MichaelAntonFischer opened this issue Sep 18, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@MichaelAntonFischer
Copy link

Hi,

I noticed that split is not always working as intended. Sometimes a split does not happen (less than 1 sat on one of the transactions, too high fee, sometimes for no reason). So it would be handy if there was an option that split periodically retries to run a split on the amount of sats in the wallet minus LNbits fee reserve.

@dni dni added the enhancement New feature or request label Sep 20, 2023
@dni
Copy link
Member

dni commented Sep 20, 2023

as of now, i think this is not possible.

to be able to do this we would need to introduce something like a split log, where we log all split and at least show failed splits. maybe with a resend button.

@MichaelAntonFischer
Copy link
Author

I think it shouldn’t be on per default, and it doesn’t need to log failed splits from my perspective. It just should take the balance in the wallet minus lnbits-fee-reserve and split that.

@dni
Copy link
Member

dni commented Sep 20, 2023

the code shows we take reserve fees into account, here https://github.com/lnbits/splitpayments/blob/main/tasks.py#L57

we have no recollection of failed payments though, it happens on the fly when a payment is received, and if a split fails, it will be deleted as transaction. so there will be no way to ever retry splits or even really see what happens, if i am not completely mistaken.

@MichaelAntonFischer
Copy link
Author

MichaelAntonFischer commented Sep 20, 2023

Correct me if I’m wrong, but isn’t the way it takes it into account that it just doesn’t do the split, if there is not enough fee on top of the incoming transaction?

My issue is that right now I already host over a dozen accounts. To not become a custodian I need a way to ensure that besides the fee reserve everything is automatically forwarded.

Essentially I do not care about any history. I just need the full wallet balance be split/scrubbed at regular intervals.

@MichaelAntonFischer
Copy link
Author

MichaelAntonFischer commented Sep 20, 2023

Of course a feature to remember and retry splits with the amount that was received would be even cooler, but overkill for my needs.

Edit:
Thinking more about this, full wallet option is needed anyways, otherways amounts where one party receives sub 1sat get stuck forever.

@MichaelAntonFischer
Copy link
Author

Use Case example:

Hosted/shared lnbits to receive tips.
1 Person should receive 50% in to their self custodial wallet.
5 others should receive 10% each into their various custodial wallets.

Setup:
Inbound Lnbits tip wallet splits to 6 outbound lnbits wallets, scrubs to the 6 external wallets.

Current behavior:
Transactions sub 10 sat get stuck in inbound many transactions get stuck in in and outbound.

Wishfull behavior:
Setting that allows scrub and split to rerun in a fixed time interval, so stuck transactions on inbound are aggregated and split and stuck transactions on outbound are aggregated and scrubbed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants