Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Orphaned cards, when a wallet is deleted - burning uids on the server #3

Open
thilohille opened this issue Mar 23, 2023 · 1 comment · May be fixed by #26
Open

Orphaned cards, when a wallet is deleted - burning uids on the server #3

thilohille opened this issue Mar 23, 2023 · 1 comment · May be fixed by #26

Comments

@thilohille
Copy link

If you delete a wallet without deleteing the cards first the cards are orphaned.

  1. Create a wallet.
  2. Enable Boltcards extension
  3. Create a Card UID=12345671234567
  4. Delete the wallet

That UID cannot be used on that server again.
Also the card cannot be deleted using the api leaving no easy way out.
grafik

Shouldnt the column "wallet" in the "cards"-table be a FOREIGN KEY with CASCADE DELETE?
grafik
@gorrdy
Copy link
Contributor

gorrdy commented Jul 14, 2023

I wouldn't check the UID at all... It only makes things harder, not easier.

It would fix this issue but also didn't force users to delete the keys from server unless they really need to. This is why there is an unique ID for each boltcard record in database. It doesn't matter if more bolt cards records (boltcards configured) does have the same UID, the server determines it with the boltcard record external_id, not the card uid.

I don't see a problem even if two users uses the same card UID (I can wipe the card but keep the keys configured, and then gitf the card to somebody to have it or just to try it for some time). Now it is not possible as mentioned in this issue.

@gorrdy gorrdy linked a pull request Oct 4, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the duplicate UID check as it is not needed. gorrdy/boltcards
2 participants
@thilohille @gorrdy