Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The call trace doesnt not include RevertReason #123

Closed
kant777 opened this issue Mar 20, 2024 · 4 comments
Closed

The call trace doesnt not include RevertReason #123

kant777 opened this issue Mar 20, 2024 · 4 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@kant777
Copy link

kant777 commented Mar 20, 2024

This does not include RevertReason https://github.com/lmittmann/w3/blob/main/module/debug/call_trace.go#L30-L41 according the spec here https://geth.ethereum.org/docs/developers/evm-tracing/built-in-tracers . see the calltracer section

@lmittmann
Copy link
Owner

PRs welcome

@lmittmann lmittmann added the good first issue Good for newcomers label Mar 21, 2024
@lmittmann lmittmann added the bug Something isn't working label Mar 30, 2024
@kamikazechaser
Copy link

There is a workaround this by "simulating" the tx. Infact it is better as it doesn't burn the usually expensive trace credits on 3rd party RPC providers.

https://github.com/grassrootseconomics/celoutils/blob/v3/simulate.go

@krishnateja262
Copy link
Contributor

@lmittmann i am interested to work on this, lmk if this issue is open for contributions

@lmittmann
Copy link
Owner

fixed in #173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants