-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AArch64][GlobalISel] Clang crashes on assertion in Legalizer #121365
Comments
@llvm/issue-subscribers-backend-aarch64 Author: Vitaly Buka (vitalybuka)
[ranges.tar.gz](https://github.com/user-attachments/files/18278564/ranges.tar.gz)
Reduced IR:
|
This bisects to #83038 |
@davemgreen @stuij @aemerson please help? |
Is this assert just wrong https://github.com/llvm/llvm-project/blob/main/llvm/lib/CodeGen/GlobalISel/MachineIRBuilder.cpp#L1185 ? |
How do we make this crash? I wasn't able to here: https://llvm.godbolt.org/z/fxnnxMzvK (I can fully believe that it would). @aemerson has been trying to fix up some of the vector-i1 lowering lately, maybe we have fixed/hidden the problem recently. |
I passed that into clang, same sh script from the gz with |
Something like this:
and to avoid store to null we can change to
|
Ah of course, it just needed -O0 to llc to prevent it being simplified. |
Nice. I also tried a little with opt, and notices that it simplifies store, but it didn't trigger with me that llc may transform it some how as well. yes, it crashes the same in MachineIRBuilder::validateTruncExt |
It looks like it doesn't handle <1 x i1> shuffle vectors (as gisel converts any |
Thank you for the quick fix, David! |
…#121352) This reverts commit 0ea40bf. Passes with #121365 fix: https://lab.llvm.org/buildbot/#/builders/55/builds/4930
ranges.tar.gz
Reduced IR:
The text was updated successfully, but these errors were encountered: