[libc] delete old hdrgen #117208
Assignees
Labels
Comments
|
@llvm/issue-subscribers-libc Author: Nick Desaulniers (nickdesaulniers)
Now that we have newhdrgen, filing a bug to track the removal of the existing hdrgen (couldn't find an existing bug for this; feel free to dupe this to that if it exists).
I've moved over the buildbots to use newhdrgen (required resetting buildbot's cmakecache). cc @petrhosek @RoseZhang03 @aaryanshukla |
|
Fairly sure no such bug existed before. Let me know if there are any issues with newhdrgen while moving the buildbots. |
Merged
nickdesaulniers
added a commit
to nickdesaulniers/llvm-project
that referenced
this issue
Nov 21, 2024
Thanks to the effort of @RoseZhang03 and @aaryanshukla under the guidance of @michaelrj-google and @amykhuang, we now have newhdrgen and no longer have a dependency on TableGen and thus LLVM in order to start bootstrapping a full build. This PR: - Removes being able to set `LIBC_HDRGEN_EXE`. - LIBC_HDRGEN_EXE; the in tree newhdrgen is the only hdrgen that can be used. - LIBC_USE_NEW_HEADER_GEN; newhdrgen is the default and only option. - LIBC_HDRGEN_ONLY; there is no need to have a distinct build step for old hdrgen. - libc-api-test and libc-api-test-tidy build targets. - Deletes all .td files. It does not rename newhdrgen to just hdrgen. Will follow up with a distinct PR for that. Link: llvm#117209 Fixes: llvm#117208
nickdesaulniers
added a commit
to nickdesaulniers/llvm-project
that referenced
this issue
Nov 21, 2024
Thanks to the effort of @RoseZhang03 and @aaryanshukla under the guidance of @michaelrj-google and @amykhuang, we now have newhdrgen and no longer have a dependency on TableGen and thus LLVM in order to start bootstrapping a full build. This PR removes: - LIBC_HDRGEN_EXE; the in tree newhdrgen is the only hdrgen that can be used. - LIBC_USE_NEW_HEADER_GEN; newhdrgen is the default and only option. - LIBC_HDRGEN_ONLY; there is no need to have a distinct build step for old hdrgen. - libc-api-test and libc-api-test-tidy build targets. - Deletes all .td files. It does not rename newhdrgen to just hdrgen. Will follow up with a distinct PR for that. Link: llvm#117209 Fixes: llvm#117208
nickdesaulniers
added a commit
to nickdesaulniers/llvm-project
that referenced
this issue
Dec 3, 2024
Thanks to the effort of @RoseZhang03 and @aaryanshukla under the guidance of @michaelrj-google and @amykhuang, we now have newhdrgen and no longer have a dependency on TableGen and thus LLVM in order to start bootstrapping a full build. This PR removes: - LIBC_HDRGEN_EXE; the in tree newhdrgen is the only hdrgen that can be used. - LIBC_USE_NEW_HEADER_GEN; newhdrgen is the default and only option. - LIBC_HDRGEN_ONLY; there is no need to have a distinct build step for old hdrgen. - libc-api-test and libc-api-test-tidy build targets. - Deletes all .td files. It does not rename newhdrgen to just hdrgen. Will follow up with a distinct PR for that. Link: llvm#117209 Fixes: llvm#117208
nickdesaulniers
added a commit
to nickdesaulniers/llvm-project
that referenced
this issue
Dec 3, 2024
Thanks to the effort of @RoseZhang03 and @aaryanshukla under the guidance of @michaelrj-google and @amykhuang, we now have newhdrgen and no longer have a dependency on TableGen and thus LLVM in order to start bootstrapping a full build. This PR removes: - LIBC_HDRGEN_EXE; the in tree newhdrgen is the only hdrgen that can be used. - LIBC_USE_NEW_HEADER_GEN; newhdrgen is the default and only option. - LIBC_HDRGEN_ONLY; there is no need to have a distinct build step for old hdrgen. - libc-api-test and libc-api-test-tidy build targets. - Deletes all .td files. It does not rename newhdrgen to just hdrgen. Will follow up with a distinct PR for that. Link: llvm#117209 Fixes: llvm#117208
nickdesaulniers
added a commit
that referenced
this issue
Dec 3, 2024
Thanks to the effort of @RoseZhang03 and @aaryanshukla under the guidance of @michaelrj-google and @amykhuang, we now have newhdrgen and no longer have a dependency on TableGen and thus LLVM in order to start bootstrapping a full build. This PR removes: - LIBC_HDRGEN_EXE; the in tree newhdrgen is the only hdrgen that can be used. - LIBC_USE_NEW_HEADER_GEN; newhdrgen is the default and only option. - LIBC_HDRGEN_ONLY; there is no need to have a distinct build step for old hdrgen. - libc-api-test and libc-api-test-tidy build targets. - Deletes all .td files. It does not rename newhdrgen to just hdrgen. Will follow up with a distinct PR for that. Link: #117209 Link: #117254 Fixes: #117208
nickdesaulniers
added a commit
that referenced
this issue
Dec 4, 2024
nickdesaulniers
added a commit
to nickdesaulniers/llvm-project
that referenced
this issue
Dec 4, 2024
Further cleanups from old hdrgen removal. I didn't realize there were cmake variables related to old hdrgen spread out throughout more of the source tree. Link: llvm#117220 Link: llvm#117208
nickdesaulniers
added a commit
to nickdesaulniers/llvm-project
that referenced
this issue
Dec 4, 2024
Further cleanups from old hdrgen removal. I didn't realize there were cmake variables related to old hdrgen spread out throughout more of the source tree. Link: llvm#117220 Link: llvm#117208
nickdesaulniers
added a commit
that referenced
this issue
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Now that we have newhdrgen, filing a bug to track the removal of the existing hdrgen (couldn't find an existing bug for this; feel free to dupe this to that if it exists).
I've moved over the buildbots to use newhdrgen (required resetting buildbot's cmakecache).
cc @petrhosek @RoseZhang03 @aaryanshukla
The text was updated successfully, but these errors were encountered: