Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lld][MachO] Implement support for -allowable_client #117113

Open
carlocab opened this issue Nov 21, 2024 · 1 comment · May be fixed by #117155
Open

[lld][MachO] Implement support for -allowable_client #117113

carlocab opened this issue Nov 21, 2024 · 1 comment · May be fixed by #117155
Labels
enhancement Improving things as opposed to bug fixing, e.g. new or missing feature lld:MachO

Comments

@carlocab
Copy link
Contributor

carlocab commented Nov 21, 2024

This is a follow-up to #114638 and #114146.

In #114638, we implemented support for respecting the allowable-client fields in libraries that were linked with -allowable_client. It is currently only possible to produce these libraries using Apple ld64.

We should teach ld64.lld to do the same. This will allow us to get rid of the liballowable_client.dylib binary test fixture (used in allowable-client.s).

It suffices to populate the LC_SUB_CLIENT field(s) in the MachO header with the name(s) passed to -allowable_client.

I plan to work on this myself, but I've opened this to make sure this is being tracked somewhere (in case I don't get to it).

@github-actions github-actions bot added the lld label Nov 21, 2024
carlocab added a commit to carlocab/llvm-project that referenced this issue Nov 21, 2024
@EugeneZelenko EugeneZelenko added enhancement Improving things as opposed to bug fixing, e.g. new or missing feature lld:MachO and removed lld labels Nov 21, 2024
@llvmbot
Copy link
Member

llvmbot commented Nov 21, 2024

@llvm/issue-subscribers-lld-macho

Author: Carlo Cabrera (carlocab)

This is a follow-up to #114638 and #114146.

In #114638, we implemented support for respecting the allowable-client fields in libraries that were linked with -allowable_client. It is currently only possible to produce these libraries using Apple ld64.

We should teach ld64.lld to do the same. This will allow us to get rid of the liballowable_client.dylib binary test fixture (used in allowable-client.s).

It suffices to populate the LC_SUB_CLIENT field(s) in the MachO header with the name(s) passed to -allowable_client.

I plan to work on this myself, but I've opened this to make sure this is being tracked somewhere (in case I don't get to it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving things as opposed to bug fixing, e.g. new or missing feature lld:MachO
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants