Skip to content

Commit 804c74f

Browse files
committed
Address comments
1 parent 9f3f31d commit 804c74f

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

llvm/include/llvm/TargetParser/Triple.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -594,8 +594,8 @@ class Triple {
594594
return (getVendor() == Triple::Apple) && isOSBinFormatMachO();
595595
}
596596

597-
/// Is this a "Darwin" OS (macOS, iOS, tvOS, watchOS, XROS, bridgeOS, or
598-
/// DriverKit).
597+
/// Is this a "Darwin" OS (macOS, iOS, tvOS, watchOS, DriverKit, XROS, or
598+
/// bridgeOS).
599599
bool isOSDarwin() const {
600600
return isMacOSX() || isiOS() || isWatchOS() || isDriverKit() || isXROS() ||
601601
isBridgeOS();

llvm/lib/MC/MCStreamer.cpp

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1453,13 +1453,9 @@ static VersionTuple getMachoBuildVersionSupportedOS(const Triple &Target) {
14531453
case Triple::WatchOS:
14541454
return VersionTuple(5);
14551455
case Triple::DriverKit:
1456-
// DriverKit always uses the build version load command.
1457-
return VersionTuple();
1458-
case Triple::XROS:
1459-
// XROS always uses the build version load command.
1460-
return VersionTuple();
14611456
case Triple::BridgeOS:
1462-
// Who knows?
1457+
case Triple::XROS:
1458+
// DriverKit/BridgeOS/XROS always use the build version load command.
14631459
return VersionTuple();
14641460
default:
14651461
break;

0 commit comments

Comments
 (0)