Skip to content

[Documentation] Encode rules for skeleton, asserts, unrecheable, testing, etc #620

@bcardosolopes

Description

@bcardosolopes
Member

Inspired by @Lancern work on providing some ASM guideline goodness, I created some guidelines for auto and camelCase usage, see it here: https://llvm.github.io/clangir/GettingStarted/coding-guideline.html

However, we still need to encode the other common review items, such as OG skeleton, asserts, unrecheable, testing, etc. It'd be nice to have that.

Activity

bcardosolopes

bcardosolopes commented on May 20, 2024

@bcardosolopes
MemberAuthor
eZWALT

eZWALT commented on Jun 10, 2024

@eZWALT
Contributor

Inspired by @Lancern work on providing some ASM guideline goodness, I created some guidelines for auto and camelCase usage, see it here: https://llvm.github.io/clangir/GettingStarted/coding-guideline.html

However, we still need to encode the other common review items, such as OG skeleton, asserts, unrecheable, testing, etc. It'd be nice to have that.

Would it make sense If I presented a proposal of Dialect intermixing guidelines? I'm guessing it could be useful for other future contributors which for instance, might want to tackle OpenACC.

bcardosolopes

bcardosolopes commented on Jun 10, 2024

@bcardosolopes
MemberAuthor

That'd be great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentationenhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @bcardosolopes@eZWALT

        Issue actions

          [Documentation] Encode rules for skeleton, asserts, unrecheable, testing, etc · Issue #620 · llvm/clangir