Hiresfix Button Behavior Reverted | Is Broken

[andy8992]

I believe you've broken the behavior if the hiresfix button. I had suggested an update to it months back and it was implemented. This last update seems to have reverted it's behavior. Tbh this is very important to me.

Expected behavior

original image 10x10
hit hiresfix button at 2x scale
new image should be 20x20 and it is indeed BUt
hit hiresfix button again at 2x scale
new image should be 40x40 but it is not. it just keeps making 20x20 images

The 2X is supposed to be applied to the currently selected photo in the gallery but it's not. Despite choosing the 20x20 image, it's not having 2X applied to it.

REALLY hope this gets fixed quickly. Guess I'll go back a version.

[MisterChief95]

It seems to be working for me on the latest commit. Ran a 2x upscale with the hires button [✨] then ran it again right after and it appears to have done what it was supposed to. I started with a 896 x 1152 image and ended with a 3584 x 4608 image.

Make sure you have this option disabled in your settings, because instead of replacing the image in the gallery after clicking the hires button, it will add it as a new image:

[andy8992]

Not going to disable that setting. It worked fine with that setting enabled a week ago. Adding a new image doesn't mean this shouldn't work as intended. It SHOULD be upscaling whichever image in the gallery I have currently selected, this was it's behavior previous to this update.

I rolled back one commit and the issue was resolved. The latest update rolled something back, I haven't looked at which scripts got changes but it seems clear that something got rolled back too much.

[MisterChief95]

I only suggested disabling the option in the event you weren't aware of its functionality. At any rate, I don't see anything in recent commits that could cause this, and as I mentioned, it works perfectly fine for me on the latest commit. We can wait and see if someone else has the same issue and hopefully narrow it down from there.