Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$1,000 bounty - Flux+highres fix+inpainting+img2img #2546

Open
x-ili-x opened this issue Jan 11, 2025 · 9 comments
Open

$1,000 bounty - Flux+highres fix+inpainting+img2img #2546

x-ili-x opened this issue Jan 11, 2025 · 9 comments

Comments

@x-ili-x
Copy link

x-ili-x commented Jan 11, 2025

I need someone to fix Flux going full static with highres fix, inpainting and img2img. If you have an install that uses Flux in these ways properly, and you can give me that instance via google drive or any other way, you get the bounty.

@x-ili-x x-ili-x changed the title $1,000 bounty - Flux+highres fix+img2img $1,000 bounty - Flux+highres fix+inpainting+img2img Jan 11, 2025
@HMRMike
Copy link

HMRMike commented Jan 11, 2025

Works fine directly from git clone.
How are we supposed to figure out if it's not some other weird issue, terrible checkpoint,or just wrong sampler/other settings?

@UnconnectedBedna
Copy link

UnconnectedBedna commented Jan 11, 2025

Works fine directly from git clone. How are we supposed to figure out if it's not some other weird issue, terrible checkpoint,or just wrong sampler/other settings?

Not in img2img, only in txt2img.
At least not on my forge installation...

Not sure why you would need it though. A better way is to just let flux generate a high res image, one of the points of flux is low steps and high resolution (IIUC).
And if that is not big enough, use extras to upscale further.
(there is also the SD-upscale in the script dropdown that might be usable)
And then you ofc also have Kohya HRFix integrated.

But who am I to question if someone wants to hand out $1000 for a feature!
A bounty is a bounty! :)

@HMRMike
Copy link

HMRMike commented Jan 11, 2025

Not in img2img, only in txt2img.

I wonder what makes it tick here, then, or fail on other systems...weird. Cloned the repo from scratch to test and "it just works".
I do have some system-wide dependencies installed separately due to xformers (but it's only active on my main install) but nothing else comes to mind, and I recall img2img working fine with flux long before that addition anyway.

image

@UnconnectedBedna
Copy link

UnconnectedBedna commented Jan 11, 2025

Highres fix:
image

Expanded:
image

Does not exist in img2img or it should be under Sampling method, like you just proved with your image. xD

@HMRMike
Copy link

HMRMike commented Jan 11, 2025

I think OP was asking about any of these features, separately, but they are all tied to img2img eventually. hires fix is img2img anyway, of course it makes no sense to have it in the img2img tab.

@UnconnectedBedna
Copy link

OP is asking for someone to implement the functionality of highres fix in img2img, not more complicated than that.
And no, highres fix does not exist in img2img, nowhere can you select to use an upscaler like R-ESRGAN.

@HMRMike
Copy link

HMRMike commented Jan 11, 2025

It's there alright. Hidden in the settings but can be also added to the img2img tab. This doesn't seem to fit the "going full static" complaint though.

image

@UnconnectedBedna
Copy link

UnconnectedBedna commented Jan 11, 2025

Go ahead and use it with flux and then instruct him how to.. $1000

I recommend using the built in Kohya HRFix integrated, or extras tab for upscaling.

@jt-michels
Copy link

jt-michels commented Jan 14, 2025

^^ , HRFix isn't compatible with Flux, but also like you said, you kind of shouldn't need it.
Flux can output high quality images up to 2.0 Megapixels, which depending on your aspect ratio is around 1448 ², or what I typically use is 1572 x 1280. Past that, the quality will begin to degrade.

I'm not entirely sure what the request is though... Is it that you are having issues with inpainting, img2img, and HiRes fix with Flux, or that you want to be able to use HiresFix with your img2img inpainting with Flux?

If it is the former, then feel free to reach out and I can check out your settings and tell you what's up, because it should work out of the box for img2img and inpainting. Hires Fix ,well... that's just a version of img2img that does not use Flux, so you'll not

If you'd like to upscale your Flux images using the (non Latent) ,Hires Fix Upscalers, you can do so in the Extras tab....

Or if you are just looking to use Hires Fix with your Flux generations from the txt2img , then again, feel free to reach out and I will check your settings and see what's going on .

As an example, Here's a kitten that I upscaled to 1936 x 1512 (almost 3.0 Mpx) txt2img with Flux and Hires fix.
It does degrade a little bit , you can see it in the eyes a bit, but overall not a bad job if you ask me.
kitty2
kitty1

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants