Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical bar are broken in Chart/Gears activities on Windows #1646

Open
llaske opened this issue Jul 10, 2024 · 8 comments
Open

Vertical bar are broken in Chart/Gears activities on Windows #1646

llaske opened this issue Jul 10, 2024 · 8 comments
Labels
bug to be release Fixed, to be release

Comments

@llaske
Copy link
Owner

llaske commented Jul 10, 2024

On Chrome Window, the vertical bar used in activities toolbar to split group of icons is broken.

It look like:

image

and should be:

image

Issue is both on Chart and Gears activity

@llaske llaske added the bug label Jul 10, 2024
@hharshas
Copy link
Contributor

hharshas commented Jul 10, 2024

yeah, actually the issue persists in one of the the other activity also (I don't remember it clearly) but the problem is in file sugarweb lib's sugar-200dpi.css file, with hr tags, rather than these particular activities. We need to make changes in each activity I guess.

@llaske
Copy link
Owner Author

llaske commented Jul 12, 2024

@hharshas do you know a way to fix it to ensure it will works in all environments?

@hharshas
Copy link
Contributor

hharshas commented Jul 13, 2024

Nothing comes to my mind easier than changing the hr tag's style in all of the activities's lib folder manually, so we can avoid this error in the future use of hr tags inside the toolbar classes in any activity. @llaske I guess if you are aware of any other way to make changes at one place and it will automatically update all sugarweb library's style files, that may come in handy.

@llaske
Copy link
Owner Author

llaske commented Jul 15, 2024

I guess if you are aware of any other way to make changes at one place and it will automatically update all sugarweb library's style files, that may come in handy.

I've got script to do the job to copy a file changed in sugarweb in every activity.
My question was more: could we find a simple implementation of the hr tag that will work in any environment (any OS any browser)?

@hharshas
Copy link
Contributor

@llaske, I need to spend some time going through the code base and other things. I'm quite busy with my internship, but if the issue remains unresolved for a while, I'll make sure to look into it.

@MdSaifAliMolla
Copy link

@llaske fixed it. #1654

@AdityaKrSingh26
Copy link

Hey @llaske could you please have a look at my pr (#1673)

@llaske
Copy link
Owner Author

llaske commented Dec 18, 2024

Fixed in #1673

@llaske llaske added the to be release Fixed, to be release label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug to be release Fixed, to be release
Projects
None yet
Development

No branches or pull requests

4 participants