Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add metric: "Require deployments to succeed before merging" #82

Open
ljharb opened this issue Apr 5, 2022 · 9 comments
Open

add metric: "Require deployments to succeed before merging" #82

ljharb opened this issue Apr 5, 2022 · 9 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed on hold

Comments

@ljharb
Copy link
Owner

ljharb commented Apr 5, 2022

This checkbox is under branch protections:
Screen Shot 2022-04-05 at 10 44 09 AM

@ljharb ljharb added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Apr 5, 2022
@ljharb
Copy link
Owner Author

ljharb commented Apr 13, 2022

@thehanimo
Copy link
Collaborator

I see a requiresStatusChecks under BranchProtectionRule. Is that it?

@ljharb
Copy link
Owner Author

ljharb commented Jun 23, 2022

It's possible this isn't in the API yet; i'll inquire.

@thehanimo
Copy link
Collaborator

Oh yea nvm. "Require status checks to pass before merging" is a different metric.

@ljharb ljharb added the on hold label Nov 29, 2022
@luis-iaggbs
Copy link

@ljharb do you know when we could have this metric included into the API rest? This is a great feature to insert in any workflow working with environments.

@ljharb
Copy link
Owner Author

ljharb commented Dec 16, 2022

@lmartinezviewnext the "on hold" label means it's not in github's api. as soon as Github adds it, we can add it here.

@KamranBiglari
Copy link

API is not available for this feature and it's not possible to select an environment if it's not deployed on that environment. environment list is only visible once it's deployed on that env for the first time.

@ljharb
Copy link
Owner Author

ljharb commented Jan 17, 2023

@KamranBiglari thanks for confirming. we could still require an environment name here, and to satisfy it, you'd have to successfully deploy it before requiring it, just like a branch protection.

@ddaniels-andmore
Copy link

This was also confusing for me as well. We are creating a step-by-step for setting up a brand new repository and would like to have this rule setup. The way it functions now requires us to create the repo, deploy it and then set the rule. Kind of backwards, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed on hold
Projects
None yet
Development

No branches or pull requests

5 participants