fix: catch fake collections throwing (chaijs#100)

Fixes chaijs#99
ljharb · Jun 3, 2024 · bf2bb4d · bf2bb4d
1 parent 0e417c7
commit bf2bb4d
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 5 deletions.
diff --git a/index.js b/index.js
@@ -274,13 +274,18 @@ function regexpEqual(leftHandOperand, rightHandOperand) {
  */
 
 function entriesEqual(leftHandOperand, rightHandOperand, options) {
-  // IE11 doesn't support Set#entries or Set#@@iterator, so we need manually populate using Set#forEach
-  if (leftHandOperand.size !== rightHandOperand.size) {
+  try {
+    // IE11 doesn't support Set#entries or Set#@@iterator, so we need manually populate using Set#forEach
+    if (leftHandOperand.size !== rightHandOperand.size) {
+      return false;
+    }
+    if (leftHandOperand.size === 0) {
+      return true;
+    }
+  } catch (sizeError) {
+    // things that aren't actual Maps or Sets will throw here
     return false;
   }
-  if (leftHandOperand.size === 0) {
-    return true;
-  }
   var leftHandItems = [];
   var rightHandItems = [];
   leftHandOperand.forEach(function gatherEntries(key, value) {

diff --git a/test/new-ecmascript-types.js b/test/new-ecmascript-types.js
@@ -97,6 +97,14 @@ describe('ES2015 Specific', function () {
       assert(eql(mapA, mapB), 'eql(Map { a => 1, b => 2, c => 3 }, Map { a => 1, b => 2, c => 3 })');
     });
 
+    (setExists ? it : it.skip)('returns false for fake Maps', function () {
+      var maplikeSet = new Set();
+      Object.defineProperty(maplikeSet, 'constructor', { enumerable: false, value: Map });
+      Object.setPrototypeOf(maplikeSet, Map.prototype);
+
+      assert(eql(maplikeSet, new Map()) === false, 'eql(Set pretending to be a Map, Map { })');
+    });
+
   });
 
   describeIf(symbolAndMapExist && typeof Map.prototype[Symbol.iterator] === 'function')('map iterator', function () {
@@ -240,6 +248,14 @@ describe('ES2015 Specific', function () {
       assert(eql(setA, setB) === true, 'eql(Set { -> }, Set { <- }) === true');
     });
 
+    (mapExists ? it : it.skip)('returns false for fake Sets', function () {
+      var setlikeMap = new Map();
+      Object.defineProperty(setlikeMap, 'constructor', { enumerable: false, value: Set });
+      Object.setPrototypeOf(setlikeMap, Set.prototype);
+
+      assert(eql(setlikeMap, new Set()) === false, 'eql(Map pretending to be a Set, Set { })');
+    });
+
   });
 
   describeIf(symbolAndSetExist && typeof Set.prototype[Symbol.iterator] === 'function')('set iterator', function () {