Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all the Solidity tests with Foundry #576

Open
RiccardoBiosas opened this issue May 16, 2022 · 0 comments
Open

Run all the Solidity tests with Foundry #576

RiccardoBiosas opened this issue May 16, 2022 · 0 comments
Assignees

Comments

@RiccardoBiosas
Copy link
Contributor

Context
At the moment the protocol code-base includes two types of Solidity tests: truffle-based Solidity tests and Foundry Solidity tests.. The truffle-based Solidity tests are run as part of the unit tests via the runSolidityTest helper.
I propose to convert them to Foundry tests to enforce more consistency in the code-base and because Foundry is the clear winner in terms of performance and testing capabilities.

TODO

  • Move the Solidity tests to the Foundry directory
  • Make the necessary refactoring to run them as tests with Foundry/forge - i.e.: replacing the before, beforeEach hooks with setUp. I'm estimating the refactoring process should be fairly straightforward
  • Remove the runSolidityTest helper
@RiccardoBiosas RiccardoBiosas self-assigned this Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant