Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter description to all AI endpoints [20 LPT] #40

Closed
rickstaa opened this issue Aug 3, 2024 · 6 comments
Closed

Add parameter description to all AI endpoints [20 LPT] #40

rickstaa opened this issue Aug 3, 2024 · 6 comments
Assignees
Labels
AI AI SPE bounties

Comments

@rickstaa
Copy link
Collaborator

rickstaa commented Aug 3, 2024

Overview

Important

This can be viewed as a retroactive bounty. I have been in discussion with a beginner bounty hunter who asked for beginner tasks, and he already completed this task yesterday (see here). Unfortunately, I didn't have time to post the bounty earlier.

The current route parameters don't have descriptions set, resulting in documentation that lacks explanations for each parameter. To fix this, we are looking for an entry-level Python programmer who can research the underlying models on Hugging Face and add descriptions to each route. This is a great first issue for anyone starting as a Livepeer Bounty Hunter 🪙⛏️ and will significantly improve the user experience of applications built on the subnet. We look forward to your submission and contributions to enhancing our documentation 🚀!

Required Skillset

This bounty is aimed at beginner programmers with little to no experience.

Bounty Requirements

Add descriptions for all parameters in the T2I, I2I, Upscale, I2V, and A2T pipelines. Ensure that these descriptions appear correctly in the documentation.

Implementation Tips

All but two parameters are directly forwarded to the underlying Hugging Face diffusers pipelines. As a result, you can find the descriptions of the route parameters in the Hugging Face documentation. Here’s how to locate the relevant documentation:

  1. Identify the Route: Go to the respective route of a given pipeline (e.g., T2I).
  2. Locate Parameters: The parameters are listed at the top of the route function.
  3. Find the Equivalent Pipeline: Go to the code of the respective pipeline, focusing on the part that contains self.ldfm (e.g., T2I pipeline).
  4. Search Hugging Face: Search for that pipeline on Hugging Face. The documentation page of the pipeline contains the parameters.

Note

Some Livepeer AI pipelines use multiple Hugging Face pipelines, so please ensure you check all relevant pipelines.

How to Apply

  1. Express Your Interest: Comment on this issue to indicate your interest and explain why you're the ideal candidate for the task.
  2. Wait for Review: Our team will review expressions of interest and select the best candidate.
  3. Get Assigned: If selected, we'll assign the GitHub issue to you.
  4. Start Working: Dive into your task! If you need assistance or guidance, comment on the issue or join the discussions in the #🛋│developer-lounge channel on our Discord server.
  5. Submit Your Work: Create a pull request in the relevant repository and request a review.
  6. Notify Us: Comment on this GitHub issue when your pull request is ready for review.
  7. Receive Your Bounty: We'll arrange the bounty payment once your pull request is approved.
  8. Gain Recognition: Your valuable contributions will be showcased in our project's changelog.

Thank you for your interest in contributing to our project 💛!

Warning

Please wait for the issue to be assigned to you before starting work. To prevent duplication of effort, submissions for unassigned issues will not be accepted.

@rickstaa rickstaa added the AI AI SPE bounties label Aug 3, 2024
@rickstaa rickstaa changed the title Add parameter description to all AI endpoints [LPT] Add parameter description to all AI endpoints [20 LPT] Aug 3, 2024
@EAsuperstar
Copy link

I'll like to take on this bounty. This will provide an excellent opportunity to familiarize myself with some new concepts.

@EAsuperstar
Copy link

EAsuperstar commented Aug 3, 2024

I have completed this bounty, please review the pull request here

@ad-astra-video
Copy link

ad-astra-video commented Aug 9, 2024

@EAsuperstar thank you for getting this going! There are a number of the descriptions that could use updates to better apply to the current implementation. See below:

For the model_id fields, can you update the example model ids to be the default models set here?

For the input files fields (image, audio), we only support input files. Do not support numpy arrays, tensors or latents. Can you update to only reference a file input?

For prompts, we only accept strings, Prompt embeds, tensors or latents cannot be passed through this field. There are also a couple other things that could be added to this description.

  • We support multiple prompts by adding a "|" to split the prompt for models that support it (SDXL-2 prompts, SD3-3 prompts).
  • Can you update to include some description how prompt_embeds will be calculated in this PR. Something quick would work, like:
    • "Add '+' after word to increase weight of word in prompt or '-' to decrease the weight of the word in the prompt"

@EAsuperstar
Copy link

EAsuperstar commented Aug 10, 2024

@ad-astra-video @rickstaa I have made changes to the descriptions as requested and made another commit, see here.
I see <gateway-ip> listed as an important parameter for all five pipelines in the docs. This is not in the code, is this a problem? I hope not.
Please review the file changes I have made, thanks.

@EAsuperstar
Copy link

The Discord code you sent me to prove ownership of the GitHub account was d00c12f7-e9e4-4ced-9ca5-7e3c9cc597b3

@rickstaa
Copy link
Collaborator Author

This was merged in livepeer/ai-worker#144 and has been paid out on the chain already 🎉. All bounty transactions can be found back on the AI SPE wallet. @EAsuperstar thanks a lot for improving the documentation 🚀.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI AI SPE bounties
Projects
None yet
Development

No branches or pull requests

3 participants