Skip to content

Commit d21eca3

Browse files
Removed the page token for now and updating some more params from phonenumber(s) to number(s)
1 parent 66546e8 commit d21eca3

File tree

1 file changed

+17
-31
lines changed

1 file changed

+17
-31
lines changed

cmd/lk/phone_number.go

Lines changed: 17 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,6 @@ var (
5050
Usage: "Maximum number of results (default: 50)",
5151
Value: 50,
5252
},
53-
&cli.StringFlag{
54-
Name: "page-token",
55-
Usage: "Token for pagination (empty for first page)",
56-
},
5753
jsonFlag,
5854
},
5955
},
@@ -63,7 +59,7 @@ var (
6359
Action: purchasePhoneNumbers,
6460
Flags: []cli.Flag{
6561
&cli.StringSliceFlag{
66-
Name: "phonenumbers",
62+
Name: "numbers",
6763
Usage: "Phone numbers to purchase (e.g., \"+1234567890\", \"+1234567891\")",
6864
Required: true,
6965
},
@@ -87,10 +83,6 @@ var (
8783
Name: "status",
8884
Usage: "Filter by status (active, pending, released)",
8985
},
90-
&cli.StringFlag{
91-
Name: "page-token",
92-
Usage: "Token for pagination (empty for first page)",
93-
},
9486
&cli.StringFlag{
9587
Name: "sip-dispatch-rule-id",
9688
Usage: "Filter by SIP dispatch rule ID",
@@ -108,11 +100,11 @@ var (
108100
Usage: "Use phone number ID for direct lookup",
109101
},
110102
&cli.StringFlag{
111-
Name: "phonenumber",
103+
Name: "number",
112104
Usage: "Use phone number string for lookup",
113105
},
114106
},
115-
ArgsUsage: "Either --id or --phonenumber must be provided",
107+
ArgsUsage: "Either --id or --number must be provided",
116108
},
117109
{
118110
Name: "update",
@@ -124,15 +116,15 @@ var (
124116
Usage: "Use phone number ID for direct lookup",
125117
},
126118
&cli.StringFlag{
127-
Name: "phonenumber",
119+
Name: "number",
128120
Usage: "Use phone number string for lookup",
129121
},
130122
&cli.StringFlag{
131123
Name: "sip-dispatch-rule-id",
132124
Usage: "SIP dispatch rule ID to assign to the phone number",
133125
},
134126
},
135-
ArgsUsage: "Either --id or --phonenumber must be provided",
127+
ArgsUsage: "Either --id or --number must be provided",
136128
},
137129
{
138130
Name: "release",
@@ -144,11 +136,11 @@ var (
144136
Usage: "Use phone number IDs for direct lookup",
145137
},
146138
&cli.StringSliceFlag{
147-
Name: "phonenumbers",
139+
Name: "numbers",
148140
Usage: "Use phone number strings for lookup",
149141
},
150142
},
151-
ArgsUsage: "Either --ids or --phonenumbers must be provided",
143+
ArgsUsage: "Either --ids or --numbers must be provided",
152144
},
153145
},
154146
},
@@ -185,9 +177,6 @@ func searchPhoneNumbers(ctx context.Context, cmd *cli.Command) error {
185177
if val := cmd.Int("limit"); val != 0 {
186178
req.Limit = int32(val)
187179
}
188-
if val := cmd.String("page-token"); val != "" {
189-
req.PageToken = &livekit.TokenPagination{Token: val}
190-
}
191180

192181
resp, err := client.SearchPhoneNumbers(ctx, req)
193182
if err != nil {
@@ -231,7 +220,7 @@ func purchasePhoneNumbers(ctx context.Context, cmd *cli.Command) error {
231220
return err
232221
}
233222

234-
phoneNumbers := cmd.StringSlice("phonenumbers")
223+
phoneNumbers := cmd.StringSlice("numbers")
235224
if len(phoneNumbers) == 0 {
236225
return fmt.Errorf("at least one phone number must be provided")
237226
}
@@ -278,9 +267,6 @@ func listPhoneNumbers(ctx context.Context, cmd *cli.Command) error {
278267
}
279268
req.Status = livekit.PhoneNumberStatus(status)
280269
}
281-
if val := cmd.String("page-token"); val != "" {
282-
req.PageToken = &livekit.TokenPagination{Token: val}
283-
}
284270
if val := cmd.String("sip-dispatch-rule-id"); val != "" {
285271
req.SipDispatchRuleId = val
286272
}
@@ -323,13 +309,13 @@ func getPhoneNumber(ctx context.Context, cmd *cli.Command) error {
323309
}
324310

325311
id := cmd.String("id")
326-
phoneNumber := cmd.String("phonenumber")
312+
phoneNumber := cmd.String("number")
327313

328314
if id == "" && phoneNumber == "" {
329-
return fmt.Errorf("either --id or --phonenumber must be provided")
315+
return fmt.Errorf("either --id or --number must be provided")
330316
}
331317
if id != "" && phoneNumber != "" {
332-
return fmt.Errorf("only one of --id or --phonenumber can be provided")
318+
return fmt.Errorf("only one of --id or --number can be provided")
333319
}
334320

335321
req := &livekit.GetPhoneNumberRequest{}
@@ -375,13 +361,13 @@ func updatePhoneNumber(ctx context.Context, cmd *cli.Command) error {
375361
}
376362

377363
id := cmd.String("id")
378-
phoneNumber := cmd.String("phonenumber")
364+
phoneNumber := cmd.String("number")
379365

380366
if id == "" && phoneNumber == "" {
381-
return fmt.Errorf("either --id or --phonenumber must be provided")
367+
return fmt.Errorf("either --id or --number must be provided")
382368
}
383369
if id != "" && phoneNumber != "" {
384-
return fmt.Errorf("only one of --id or --phonenumber can be provided")
370+
return fmt.Errorf("only one of --id or --number can be provided")
385371
}
386372

387373
req := &livekit.UpdatePhoneNumberRequest{}
@@ -421,13 +407,13 @@ func releasePhoneNumbers(ctx context.Context, cmd *cli.Command) error {
421407
}
422408

423409
ids := cmd.StringSlice("ids")
424-
phoneNumbers := cmd.StringSlice("phonenumbers")
410+
phoneNumbers := cmd.StringSlice("numbers")
425411

426412
if len(ids) == 0 && len(phoneNumbers) == 0 {
427-
return fmt.Errorf("either --ids or --phonenumbers must be provided")
413+
return fmt.Errorf("either --ids or --numbers must be provided")
428414
}
429415
if len(ids) > 0 && len(phoneNumbers) > 0 {
430-
return fmt.Errorf("only one of --ids or --phonenumbers can be provided")
416+
return fmt.Errorf("only one of --ids or --numbers can be provided")
431417
}
432418

433419
req := &livekit.ReleasePhoneNumbersRequest{}

0 commit comments

Comments
 (0)