fix(inference): claim word alignment for xai/stt-2 - #7503
Open
muntazir868 wants to merge 1 commit into
Open
muntazir868 wants to merge 1 commit into
muntazir868 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #7467 (item 3 of 3 — the word-alignment gap). Items 1 and 2 (keyterm forwarding,
smart_turn) need gateway-sidexai.ExtraSettingssupport: the gateway currently rejects those keys withfailed to decode extra settings: 'xai.ExtraSettings' has invalid keys, so they can't be fixed from this repo alone.Summary
xai/stt-2toXaiModelsso it is a first-classinference.STTmodel in the type union (STTModels).xai/stt-2to_WORD_ALIGNED_MODELS. The issue verified 48 timed words come back through Inference forxai/stt-2, same asxai/stt-1, but the capability claim still reportedFalse.What the claim actually gates
Correcting the issue description: the claim does not control adaptive interruption — interruption detection no longer consults STT alignment (decoupled from word timestamps by #6765). What it does feed:
AudioRecognitionreceives it fromagent_activity.py:883/:1319, and when the provider omitsspeech_end_time,audio_recognition.py:1147-1155derives it from the word timings. Without the claim,xai/stt-2fell back to a cruder speech-end estimate despite returning timed words.stt.FallbackAdapterreports the combined claim as"word"only if all fallback models claim alignment, so a single unaligned model degrades the whole adapter's claim for downstream consumers.Testing
make check(ruff format + lint, mypy strict) — cleanuv run pytest --unit --audio_eot --ignore=tests/test_room.py— 4012 passed, 3 skippedtests/test_inference_stt_aligned_transcript_claim.py:xai/stt-1andxai/stt-2both report"word"as the primary modelaligned-xai-stt2-fallback:fallback="xai/stt-2"keeps the adapter's claim at"word"