Skip to content

Commit e1854f7

Browse files
authored
Fix the simulations CI job: lk agent simulate needs the text subcommand (#107)
Since livekit-cli v2.18, the root `lk agent simulate` command only prints help and exits 0; the mode is a required subcommand (`text` or `audio`). The simulations job has been running the old flat form, so it has been passing without starting a single simulation. Switch the job and the four places that show the command to `lk agent simulate text --scenarios scenarios.yaml`. Text mode is the right mode for CI: it exercises the LLM, tools and conversation logic without the audio pipeline, and is scheduled so it doesn't compete with live sessions for inference.
1 parent 8d56638 commit e1854f7

4 files changed

Lines changed: 5 additions & 5 deletions

File tree

‎.github/workflows/simulations.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Runs the scenarios in scenarios.yaml against your agent on LiveKit Cloud.
22
# Simulations spend real inference, so this runs on merges to main and on demand
33
# rather than on every pull request push. Run
4-
# `lk agent simulate --scenarios scenarios.yaml` locally while iterating.
4+
# `lk agent simulate text --scenarios scenarios.yaml` locally while iterating.
55
name: Simulations
66

77
on:
@@ -43,4 +43,4 @@ jobs:
4343
run: curl -sSL https://get.livekit.io/cli | bash
4444

4545
- name: Run simulations
46-
run: lk agent simulate --scenarios scenarios.yaml
46+
run: lk agent simulate text --scenarios scenarios.yaml

‎AGENTS.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ Voice AI agents are highly sensitive to excessive latency. For this reason, it's
4242

4343
## Testing
4444

45-
When possible, add tests for agent behavior. Add a scenario to `scenarios.yaml` and run it with `lk agent simulate --scenarios scenarios.yaml`. The scenarios run in CI on every merge to main; read the [simulations documentation](https://docs.livekit.io/agents/start/testing/simulations/) before editing them.
45+
When possible, add tests for agent behavior. Add a scenario to `scenarios.yaml` and run it with `lk agent simulate text --scenarios scenarios.yaml`. The scenarios run in CI on every merge to main; read the [simulations documentation](https://docs.livekit.io/agents/start/testing/simulations/) before editing them.
4646

4747
For turn-level checks that don't need a live session, use the in-process [testing framework](https://docs.livekit.io/agents/start/testing/); `tests/test_agent.py` has a commented-out example. Run those with `uv run pytest`.
4848

‎README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ For advanced customization, see the [complete frontend guide](https://docs.livek
148148
Simulations run full multi-turn conversations between a simulated user and your agent on LiveKit Cloud, then judge each transcript. The scenarios live in [`scenarios.yaml`](scenarios.yaml). Run them locally with the [LiveKit CLI](https://docs.livekit.io/intro/basics/cli/):
149149

150150
```console
151-
lk agent simulate --scenarios scenarios.yaml
151+
lk agent simulate text --scenarios scenarios.yaml
152152
```
153153

154154
The `Simulations` workflow in `.github/workflows/simulations.yml` runs the same file on every merge to `main` and on demand from the Actions tab. It runs there rather than on every pull request push because each run spends real inference. See the [simulations guide](https://docs.livekit.io/agents/start/testing/simulations/) for how to write scenarios and read results.

‎scenarios.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Simulation scenarios for the starter assistant. Each one is a conversation a
22
# simulated user has with your agent, judged against agent_expectations. Run them
3-
# with `lk agent simulate --scenarios scenarios.yaml`; the Simulations workflow
3+
# with `lk agent simulate text --scenarios scenarios.yaml`; the Simulations workflow
44
# runs them on every merge to main.
55
#
66
# Add a scenario whenever you change instructions or add a tool, and pin any dates

0 commit comments

Comments
 (0)