Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tags of hander.Faults and handler.Spec structs #4929

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

chavacava
Copy link

@chavacava chavacava commented Oct 25, 2024

Proposed changes

Fix tags of handler.Faults struct

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

Found with revive

@chavacava chavacava changed the title fix tags of hander.Faults struct fix tags of hander.Faults and handler.Spec structs Oct 25, 2024
@namkyu1999 namkyu1999 added good first issue need-approvers-review Reminder label to the codeowners/maintainers for stale PRs that are more that 2 weeks old labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue need-approvers-review Reminder label to the codeowners/maintainers for stale PRs that are more that 2 weeks old
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants