Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Fix ] : Gitops trigger in Save, Delete, and Update Experiment #4435

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

Nageshbansal
Copy link
Contributor

@Nageshbansal Nageshbansal commented Feb 13, 2024

Proposed changes

Fixes #4434. This PR adds the checks for gitops update in following handlers

  1. SaveChaosExperiment
  2. CreateChaosExperiment
  3. UpdateChaosExperiment

I think we need to discuss this a little bit more: whether we want the gitops to be triggered while just saving the chaosExperiment or also when a new experiment is scheduled to be running

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

@Nageshbansal Nageshbansal changed the title Fixes gitops pushes to repo Fixes Gitops triggered while saving the chaos Experiment Feb 13, 2024
@Nageshbansal Nageshbansal marked this pull request as draft February 14, 2024 21:03
@Nageshbansal Nageshbansal marked this pull request as ready for review February 17, 2024 10:52
@Nageshbansal Nageshbansal changed the title Fixes Gitops triggered while saving the chaos Experiment Fixes Gitops trigger in saving the chaos Experiment Feb 17, 2024
@Nageshbansal Nageshbansal changed the title Fixes Gitops trigger in saving the chaos Experiment Fixes Gitops trigger in SaveChaosExperiment Feb 17, 2024
@Saranya-jena
Copy link
Contributor

@Nageshbansal can you check why the backend UT is failing?

@Nageshbansal
Copy link
Contributor Author

Sure @Saranya-jena checking it now ( missed the comment )

@Nageshbansal Nageshbansal changed the title Fixes Gitops trigger in SaveChaosExperiment [ Fix ] : Gitops trigger in SaveChaosExperiment Mar 1, 2024
@Nageshbansal Nageshbansal changed the title [ Fix ] : Gitops trigger in SaveChaosExperiment [ Fix ] : Gitops trigger in Save, Delete, and Update Experiment Mar 7, 2024
@Nageshbansal
Copy link
Contributor Author

PTAL @amityt @Saranya-jena @namkyu1999

@Saranya-jena Saranya-jena merged commit 547a367 into litmuschaos:master Mar 12, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gitops not getting triggered
4 participants