-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ Fix ] : Gitops trigger in Save, Delete, and Update Experiment #4435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nageshbansal
changed the title
Fixes gitops pushes to repo
Fixes Gitops triggered while saving the chaos Experiment
Feb 13, 2024
Nageshbansal
changed the title
Fixes Gitops triggered while saving the chaos Experiment
Fixes Gitops trigger in saving the chaos Experiment
Feb 17, 2024
Nageshbansal
changed the title
Fixes Gitops trigger in saving the chaos Experiment
Fixes Gitops trigger in SaveChaosExperiment
Feb 17, 2024
Saranya-jena
requested review from
namkyu1999,
Saranya-jena,
SarthakJain26 and
amityt
and removed request for
namkyu1999 and
Saranya-jena
February 23, 2024 06:43
Saranya-jena
approved these changes
Feb 23, 2024
@Nageshbansal can you check why the backend UT is failing? |
Sure @Saranya-jena checking it now ( missed the comment ) |
SarthakJain26
approved these changes
Mar 1, 2024
Nageshbansal
changed the title
Fixes Gitops trigger in SaveChaosExperiment
[ Fix ] : Gitops trigger in SaveChaosExperiment
Mar 1, 2024
namkyu1999
approved these changes
Mar 1, 2024
Nageshbansal
changed the title
[ Fix ] : Gitops trigger in SaveChaosExperiment
[ Fix ] : Gitops trigger in Save, Delete, and Update Experiment
Mar 7, 2024
Signed-off-by: nagesh bansal <[email protected]>
Signed-off-by: nagesh bansal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes #4434. This PR adds the checks for gitops update in following handlers
I think we need to discuss this a little bit more: whether we want the gitops to be triggered while just saving the chaosExperiment or also when a new experiment is scheduled to be running
Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: