Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement otel telemetry sdk for distributed tracing #221

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

feat: implement otel telemetry sdk for distributed tracing #221

wants to merge 10 commits into from

Conversation

namkyu1999
Copy link
Member

@namkyu1999 namkyu1999 commented Jul 4, 2024 •
edited
Loading

What this PR does / why we need it:

This pr implements opentelemetry codes according to this proposal.

Parent context and OTEL endpoint are passed through env(TRACE_PARENT, OTEL_EXPORTER_OTLP_ENDPOINT)

Result is like below

Screenshot 2024-07-05 at 2 20 11 PM

relevant PRs

Checklist:

  • Fixes #
  • Labelled this PR & related issue with documentation tag
  • PR messages has document related information
  • Labelled this PR & related issue with breaking-changes tag
  • PR messages has breaking changes related information
  • Labelled this PR & related issue with requires-upgrade tag
  • PR messages has upgrade related information
  • Commit has unit tests
  • Commit has integration tests

@namkyu1999
feat: implement otel sdk
5af262e 
Signed-off-by: namkyu1999 <[email protected]>
@namkyu1999 namkyu1999 mentioned this pull request Jul 4, 2024
Merged
9 tasks
namkyu1999 added 2 commits July 4, 2024 11:22
@namkyu1999
fix: update endpoint
f6e11c5 
Signed-off-by: namkyu1999 <[email protected]>
@namkyu1999
fix: fix context logic
e777dbf 
Signed-off-by: namkyu1999 <[email protected]>
This was referenced Jul 5, 2024
Draft
Merged
Draft
@namkyu1999 namkyu1999 marked this pull request as draft October 7, 2024 04:05
@namkyu1999 namkyu1999 marked this pull request as ready for review October 31, 2024 04:44
@namkyu1999
chore
dc83b1f 
Signed-off-by: namkyu1999 <[email protected]>
@namkyu1999
feat: go version from 1.20 to 1.22
32bc86c 
Signed-off-by: namkyu1999 <[email protected]>
@namkyu1999 namkyu1999 requested a review from ispeakc0de October 31, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksatchit ksatchit Awaiting requested review from ksatchit ksatchit is a code owner

@uditgaurav uditgaurav Awaiting requested review from uditgaurav uditgaurav is a code owner

@ispeakc0de ispeakc0de Awaiting requested review from ispeakc0de ispeakc0de is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Open Source Contribution Academy 2024
Status: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@namkyu1999 @ispeakc0de