Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec.components.runner.runnerAnnotations of ChaosEngine CR seems not working #503

Closed
aek-dsk opened this issue Oct 10, 2024 · 2 comments
Closed

Comments

@aek-dsk
Copy link

aek-dsk commented Oct 10, 2024

Is this a BUG REPORT or FEATURE REQUEST?

BUG REPORT

What happened:
Applying spec.components.runner.runnerAnnotations of the ChaosEngine CR in litmuschaos.io/v1alpha1 does not generate the requested annotation on the runner pod. The functionality seems to be broken. In addition, some inconsistencies between documentation, CRD, source code were found, e.g. here: https://litmuschaos.github.io/litmus/experiments/concepts/chaos-resources/chaos-engine/runner-components/ in the schema description - runnerAnnotations vs runnerAnnotation, or the source code

WithAnnotations(engine.Instance.Spec.Components.Runner.RunnerAnnotation).

What you expected to happen:
runner annotations to be correctly applied

How to reproduce it (as minimally and precisely as possible):
by trying to apply this option

Anything else we need to know?:
Could you please check?

@aek-dsk
Copy link
Author

aek-dsk commented Oct 10, 2024

Example:

spec:
  components:
    runner:
      runnerAnnotations:
        sidecar.istio.io/inject: "false"

@aek-dsk
Copy link
Author

aek-dsk commented Oct 14, 2024

For anybody stumbling upon this: there is an undocumented option in the chaosengine CRD that can be used instead: runnerLabels

spec:
  components:
    runner:
      runnerLabels:
        sidecar.istio.io/inject: "false"

@aek-dsk aek-dsk closed this as completed Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant