Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report scan PR github check #167

Open
fntlnz opened this issue Mar 22, 2023 · 0 comments
Open

report scan PR github check #167

fntlnz opened this issue Mar 22, 2023 · 0 comments
Labels
enhancement New feature or request needs-triage Mantainers team needs to take a first look at the issue

Comments

@fntlnz
Copy link
Contributor

fntlnz commented Mar 22, 2023

Describe the feature or problem you’d like to solve

We want to have a PR github check when we analyse a PR via the lstn scan --reporter=github-pr-review reporter.

Proposed solution

How will it benefit CLI and its users?

  • the users will be able to see a progress directly in the PR while its being analysed
  • the progress is there even if the user is not using lstn via a github action but maybe locally or using another CI

How to do it:

Probably, adding a NotifyStatusChange or something similar to the reporter interface and calling it accordingly at start/end/error would do the trick. On the github-pr-review reporter we can just do the checks and we can ignore or implement it differently in future reporters.

Additional context

Right now, when the user uses our action the ugly status check is showed with a not so nice icon and text (basically the action's default)
Screenshot 2023-03-22 at 02 09 04

We would ideally want to show something like this:

Screenshot 2023-03-22 at 02 13 04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-triage Mantainers team needs to take a first look at the issue
Projects
None yet
Development

No branches or pull requests

1 participant