Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use standard maps lib instead of experimental one #2860

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

fra98
Copy link
Member

@fra98 fra98 commented Dec 10, 2024

Description

This PR replaces the experimental package golang.org/x/exp/maps with the new maps package from the standard Go library.

@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@fra98 fra98 added the kind/cleanup Refactoring code label Dec 10, 2024
@fra98 fra98 force-pushed the frt/remove-exp-libs branch from a786b82 to 7aa40b7 Compare December 11, 2024 08:54
@fra98 fra98 requested review from cheina97 and aleoli December 11, 2024 08:54
@cheina97
Copy link
Member

/rebase test=true

@cheina97
Copy link
Member

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Dec 11, 2024
@adamjensenbot adamjensenbot merged commit 2642869 into liqotech:master Dec 11, 2024
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants