Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IPAM] Refactor configuration controller #2807

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

fra98
Copy link
Member

@fra98 fra98 commented Nov 6, 2024

Description

This PR refactors the configuration controller to support the new IPAM

@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@fra98 fra98 force-pushed the frt/conf-controller branch 2 times, most recently from 5604607 to e36dd91 Compare November 11, 2024 09:10
@fra98 fra98 marked this pull request as ready for review November 11, 2024 09:12
@fra98 fra98 requested review from aleoli and cheina97 November 11, 2024 09:12
@fra98 fra98 added the kind/cleanup Refactoring code label Nov 11, 2024
@fra98 fra98 force-pushed the frt/conf-controller branch from e36dd91 to d89bda6 Compare November 12, 2024 10:00
@fra98 fra98 merged commit 9305522 into liqotech:ipam Nov 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants