Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IPAM] Sync routine #2798

Merged
merged 1 commit into from
Nov 11, 2024
Merged

[IPAM] Sync routine #2798

merged 1 commit into from
Nov 11, 2024

Conversation

fra98
Copy link
Member

@fra98 fra98 commented Oct 30, 2024

Description

This PR implements the sync routine for the internal IPAM state.

@fra98 fra98 added the kind/feature New feature or request label Oct 30, 2024
@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@fra98 fra98 force-pushed the frt/ipam-sync-routine branch 5 times, most recently from 554eea9 to 1577c1e Compare November 4, 2024 11:14
@pull-request-size pull-request-size bot added size/XL and removed size/L labels Nov 4, 2024
@fra98 fra98 force-pushed the frt/ipam-sync-routine branch from f16d02a to b317f10 Compare November 4, 2024 16:15
@pull-request-size pull-request-size bot added size/L and removed size/XL labels Nov 4, 2024
@fra98 fra98 marked this pull request as ready for review November 4, 2024 16:15
@fra98 fra98 force-pushed the frt/ipam-sync-routine branch from a56be98 to dd12b83 Compare November 6, 2024 16:00
aleoli
aleoli approved these changes Nov 11, 2024
View reviewed changes
cmd/ipam/main.go Show resolved Hide resolved
@fra98 fra98 merged commit ea7f48c into liqotech:ipam Nov 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleoli aleoli aleoli approved these changes

@cheina97 cheina97 Awaiting requested review from cheina97

@claudiolor claudiolor Awaiting requested review from claudiolor

Assignees
No one assigned
Labels
kind/feature New feature or request size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fra98 @adamjensenbot @aleoli