Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump golangci-lint and gci #2064

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Bump golangci-lint and gci #2064

merged 1 commit into from
Oct 5, 2023

Conversation

fra98
Copy link
Member

@fra98 fra98 commented Oct 5, 2023

Description

This PR bumps golangci-lint and gci

@fra98 fra98 requested a review from cheina97 October 5, 2023 13:26
@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@fra98
Copy link
Member Author

fra98 commented Oct 5, 2023

/test

@cheina97
Copy link
Member

cheina97 commented Oct 5, 2023

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Oct 5, 2023
@adamjensenbot adamjensenbot merged commit 8e05bb4 into liqotech:master Oct 5, 2023
9 checks passed
@adamjensenbot adamjensenbot added merge-requested Request bot merging (automatically managed) and removed merge-requested Request bot merging (automatically managed) labels Oct 5, 2023
@aleoli aleoli added the kind/cleanup Refactoring code label Oct 24, 2023
@p-linnane p-linnane mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheina97 cheina97 cheina97 approved these changes

Assignees
No one assigned
Labels
kind/cleanup Refactoring code size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fra98 @adamjensenbot @cheina97 @aleoli