Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Controller client timeout #1991

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Controller client timeout #1991

merged 1 commit into from
Sep 8, 2023

Conversation

cheina97
Copy link
Member

@cheina97 cheina97 commented Sep 8, 2023

Description

This PR introduces the possibility of setting the timeout of the controllers' client from helm values extra-args.
It also inserts the possibility to specify common extra-args that will be applied to all the Liqo pods.

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97 cheina97 added the kind/feature New feature or request label Sep 8, 2023
@cheina97 cheina97 force-pushed the frc/timeout branch 2 times, most recently from b19fc9d to 89e414d Compare September 8, 2023 10:10
@cheina97
Copy link
Member Author

cheina97 commented Sep 8, 2023

/build

@Sharathmk99
Copy link
Contributor

Thank you so much. Looking forward to test it out.

@cheina97
Copy link
Member Author

cheina97 commented Sep 8, 2023

/rebase test=true

aleoli
aleoli approved these changes Sep 8, 2023
View reviewed changes
pkg/utils/restcfg/ratelimiting.go Outdated Show resolved Hide resolved
@cheina97
Copy link
Member Author

cheina97 commented Sep 8, 2023

/rebase test=true

@cheina97
Copy link
Member Author

cheina97 commented Sep 8, 2023

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Sep 8, 2023
@adamjensenbot adamjensenbot merged commit 004a0cf into liqotech:master Sep 8, 2023
8 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Sep 8, 2023
@cheina97 cheina97 deleted the frc/timeout branch September 8, 2023 17:22
@krehel krehel mentioned this pull request Sep 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frisso frisso frisso left review comments

@aleoli aleoli aleoli approved these changes

Assignees
No one assigned
Labels
kind/feature New feature or request size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cheina97 @adamjensenbot @Sharathmk99 @frisso @aleoli