Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Liqo-route: liqo.host forward #1979

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Liqo-route: liqo.host forward #1979

merged 1 commit into from
Sep 7, 2023

Conversation

cheina97
Copy link
Member

@cheina97 cheina97 commented Sep 4, 2023

Description

This PR adds INPUT, FORWARDING, and OUTPUT rules in liqo-gateway (checks the image)

Liqo-gateway is able to put these rules on the host network namespace of the node where the liqo-gateway is scheduled.
This solves an issue with some calico configurations where the CNI blocks the traffic from liqo.host to the liqo.vxlan interface.

image

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97 cheina97 force-pushed the frc/route branch 3 times, most recently from 4e5fa2c to 60938a2 Compare September 4, 2023 15:06
@pull-request-size pull-request-size bot added size/L and removed size/M labels Sep 4, 2023
@cheina97 cheina97 marked this pull request as ready for review September 4, 2023 15:07
@cheina97
Copy link
Member Author

cheina97 commented Sep 4, 2023

/rebase test=true

@cheina97 cheina97 force-pushed the frc/route branch 2 times, most recently from c25a254 to d9bd43b Compare September 4, 2023 15:42
@cheina97
Copy link
Member Author

cheina97 commented Sep 4, 2023

/rebase test=true

@cheina97
Copy link
Member Author

cheina97 commented Sep 4, 2023

/rebase test=true

@cheina97 cheina97 requested review from aleoli and fra98 September 4, 2023 16:55
@cheina97 cheina97 added the kind/feature New feature or request label Sep 4, 2023
@cheina97 cheina97 linked an issue Sep 5, 2023 that may be closed by this pull request
Liqo cannot peer Linode k8s clusters #1972
Closed
aleoli
aleoli approved these changes Sep 6, 2023
View reviewed changes
internal/liqonet/tunnel-operator/firewall.go Show resolved Hide resolved
internal/liqonet/tunnel-operator/firewall.go Outdated Show resolved Hide resolved
internal/liqonet/tunnel-operator/tunnel-operator.go Outdated Show resolved Hide resolved
@cheina97 cheina97 force-pushed the frc/route branch 2 times, most recently from c69f535 to 9c60e4c Compare September 7, 2023 07:58
@cheina97
Copy link
Member Author

cheina97 commented Sep 7, 2023

/rebase test=true

@cheina97
Copy link
Member Author

cheina97 commented Sep 7, 2023

/merge

@adamjensenbot adamjensenbot added merge-requested Request bot merging (automatically managed) and removed merge-requested Request bot merging (automatically managed) labels Sep 7, 2023
@cheina97
Copy link
Member Author

cheina97 commented Sep 7, 2023

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Sep 7, 2023
@adamjensenbot adamjensenbot merged commit 0c8a3e2 into liqotech:master Sep 7, 2023
8 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Sep 7, 2023
@krehel krehel mentioned this pull request Sep 19, 2023
Merged
@cheina97 cheina97 deleted the frc/route branch November 14, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleoli aleoli aleoli approved these changes

@fra98 fra98 Awaiting requested review from fra98

Assignees
No one assigned
Labels
kind/feature New feature or request size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Liqo cannot peer Linode k8s clusters
3 participants
@cheina97 @adamjensenbot @aleoli