Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IPAM] Grace Period #2838

Merged
merged 1 commit into from
Dec 5, 2024
Merged

[IPAM] Grace Period #2838

merged 1 commit into from
Dec 5, 2024

Conversation

cheina97
Copy link
Member

@cheina97 cheina97 commented Dec 2, 2024

Description

This PR introduces a timestamp inside the IPAM to wait before ips or networks deletion.

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97 cheina97 marked this pull request as draft December 2, 2024 14:58
@cheina97
Copy link
Member Author

cheina97 commented Dec 2, 2024

/build

@cheina97 cheina97 marked this pull request as ready for review December 2, 2024 16:22
@cheina97 cheina97 force-pushed the frc/ipamtimespamt branch 2 times, most recently from 047c5d1 to 03fdfb3 Compare December 5, 2024 08:35
@cheina97
Copy link
Member Author

cheina97 commented Dec 5, 2024

/build

pkg/ipam/sync.go Outdated Show resolved Hide resolved
pkg/ipam/graphviz/10_0_0_0_8.dot Outdated Show resolved Hide resolved
pkg/ipam/core/ipam.go Outdated Show resolved Hide resolved
pkg/ipam/core/ipam.go Show resolved Hide resolved
pkg/ipam/core/node.go Show resolved Hide resolved
pkg/ipam/sync_test.go Outdated Show resolved Hide resolved
pkg/ipam/sync_test.go Outdated Show resolved Hide resolved
@cheina97
Copy link
Member Author

cheina97 commented Dec 5, 2024

/rebase test=true

@fra98 fra98 merged commit c975f4e into liqotech:ipam Dec 5, 2024
13 checks passed
@cheina97 cheina97 deleted the frc/ipamtimespamt branch December 5, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants