Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPAM API: create associated Services for IP resources #2027

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

fra98
Copy link
Member

@fra98 fra98 commented Sep 18, 2023

Description

Added support for creating a Service (and EndpointSlice) associated to an IP resource.

Ref #1990

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • locally

@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@fra98 fra98 force-pushed the frt/ipam-with-svc branch 2 times, most recently from 5e28554 to 4b38545 Compare September 19, 2023 14:26
@fra98 fra98 marked this pull request as ready for review September 19, 2023 14:31
@fra98 fra98 requested review from cheina97 and aleoli September 19, 2023 14:31
apis/ipam/v1alpha1/ip_types.go Show resolved Hide resolved
pkg/virtualKubelet/reflection/exposition/endpointslice.go Outdated Show resolved Hide resolved
@fra98 fra98 requested a review from aleoli September 20, 2023 10:54
@fra98 fra98 force-pushed the frt/ipam-with-svc branch 2 times, most recently from 6de65ac to 6e3eb53 Compare September 20, 2023 11:20
@fra98 fra98 force-pushed the frt/ipam-with-svc branch 2 times, most recently from da57cbc to e6f20a0 Compare September 20, 2023 13:52
apis/ipam/v1alpha1/ip_types.go Show resolved Hide resolved
@fra98 fra98 merged commit 5564841 into liqotech:network-general Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants