Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: set update-dates on STAC item TDE-1298 #1180

Merged
merged 5 commits into from
Nov 25, 2024

Conversation

schmidtnz
Copy link
Contributor

@schmidtnz schmidtnz commented Nov 20, 2024

Motivation

As a public bucket Imagery or Elevation consumer I want to know what new datasets have been added, what datasets have had changes, what metadata has changed, so that I can keep my data and processes in sync with data referenced from the public buckets.
When an ODR path is provided to the imagery-standardising workflow, look up previously published STAC Item documents (by filename) and use them if the files are unchanged (file size and checksum).

Modifications

  • Entry point standardise_validate.py:
    • Added --current-datetime argument (defaults to "today" to avoid making a breaking change).
    • Added --odr-url optional argument.
  • ImageryItem:
    • Added classmethod to load an existing Item from file/s3.
    • Added set_checksum() method which will set the asset.visual.file:checksum and associated attributes if the given checksum differs from the current checksum.
    • Removed now_string from class init. Created/updated dates now set through respective asset properties.
    • Associated changes to reflect updated signature in all tests.
    • ....

Verification

Added and modified tests for item, collection, create_item, create_stac and collection_from_items.
Manual end-to-end test using a custom argo workflow.
GitHub actions updated.

@schmidtnz schmidtnz added the container Publish a container label Nov 20, 2024
@schmidtnz schmidtnz force-pushed the feat/keep-create-date-on-resupply-tde-1298 branch from 947b02f to 3d32bb2 Compare November 21, 2024 02:24
# Conflicts:
#	scripts/stac/imagery/create_stac.py
@schmidtnz schmidtnz added container Publish a container and removed container Publish a container labels Nov 21, 2024
@schmidtnz schmidtnz marked this pull request as ready for review November 24, 2024 19:51
@schmidtnz schmidtnz requested a review from a team as a code owner November 24, 2024 19:51
scripts/stac/imagery/item.py Outdated Show resolved Hide resolved
scripts/stac/imagery/item.py Outdated Show resolved Hide resolved
@l0b0 l0b0 enabled auto-merge November 24, 2024 23:50
@l0b0 l0b0 disabled auto-merge November 24, 2024 23:50
l0b0
l0b0 previously approved these changes Nov 25, 2024
@schmidtnz schmidtnz changed the title feat: set update-dates on STAC item TDE-1298 feat!: set update-dates on STAC item TDE-1298 Nov 25, 2024
@schmidtnz schmidtnz added this pull request to the merge queue Nov 25, 2024
Merged via the queue into master with commit 9d95b02 Nov 25, 2024
2 checks passed
@schmidtnz schmidtnz deleted the feat/keep-create-date-on-resupply-tde-1298 branch November 25, 2024 19:40
@github-actions github-actions bot mentioned this pull request Nov 25, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 27, 2024
🤖 I have created a release *beep* *boop*
---


## [7.0.0](v6.0.0...v7.0.0)
(2024-11-27)


### ⚠ BREAKING CHANGES

* set update-dates on STAC item TDE-1298
([#1180](#1180))

### Features

* defaults for current-datetime argument TDE-1298
([#1193](#1193))
([fa003f8](fa003f8))
* keep Collection properties.created date when resupplying
([#1160](#1160))
([8af3e21](8af3e21))
* set update-dates on STAC item TDE-1298
([#1180](#1180))
([9d95b02](9d95b02))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
container Publish a container
Development

Successfully merging this pull request may close these issues.

3 participants