Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Create asset summaries investigation #150

Merged
merged 8 commits into from
Nov 29, 2021

Conversation

l0b0
Copy link
Contributor

@l0b0 l0b0 commented Nov 10, 2021

Investigation into creating asset summaries - looks like it's actually pretty simple.

You can try the notebook yourself by running nix-shell --run 'jupyter lab extensions/linz/notebooks/asset-datetime-summary.ipynb'. It's my first notebook, so be gentle :)

@l0b0 l0b0 requested review from blacha, dwsilk and billgeo November 10, 2021 01:46
@l0b0 l0b0 force-pushed the docs/create-asset-summaries branch from c5fa6ad to 65b2513 Compare November 10, 2021 01:52
Looks like it would be simple to extend the `summaries` property to
allow asset-specific summaries by referring back to the definition of
the `summaries` property.

You can try the notebook yourself by running `nix-shell --run 'jupyter
lab extensions/linz/notebooks/asset-datetime-summary.ipynb'`.
@l0b0 l0b0 force-pushed the docs/create-asset-summaries branch 2 times, most recently from 3ebeb37 to 35cda06 Compare November 10, 2021 02:20
@l0b0 l0b0 marked this pull request as draft November 10, 2021 02:49
@l0b0 l0b0 force-pushed the docs/create-asset-summaries branch from 35cda06 to f7cdaef Compare November 10, 2021 03:52
@l0b0 l0b0 marked this pull request as ready for review November 10, 2021 03:53
Looks like it would be simple to extend the `summaries` property to
allow asset-specific summaries by referring back to the definition of
the `summaries` property.

You can try the notebook yourself by running `nix-shell --run 'jupyter
lab extensions/linz/notebooks/asset-datetime-summary.ipynb'`.
@l0b0 l0b0 force-pushed the docs/create-asset-summaries branch from f7cdaef to 17a4137 Compare November 10, 2021 03:57
@l0b0 l0b0 requested a review from MitchellPaff November 15, 2021 00:24
@l0b0 l0b0 added the automerge kodiak automerge label label Nov 15, 2021
@dwsilk
Copy link
Member

dwsilk commented Nov 17, 2021

Relevant to the suggestion posted in this comment: radiantearth/stac-spec#1153 (comment). Discussion ongoing.

@l0b0
Copy link
Contributor Author

l0b0 commented Nov 21, 2021

@dwsilk Should I close this, or do we want to keep the investigation?

@billgeo
Copy link
Contributor

billgeo commented Nov 24, 2021

Is this something we would merge @l0b0 or should it just be closed as having served its purpose?

@l0b0
Copy link
Contributor Author

l0b0 commented Nov 24, 2021

Is this something we would merge @l0b0 or should it just be closed as having served its purpose?

It doesn't need to be merged, but it might serve as a useful example of such an investigation for future ones.

Copy link
Contributor

@billgeo billgeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me.

@kodiakhq kodiakhq bot merged commit e5d0f86 into master Nov 29, 2021
@kodiakhq kodiakhq bot deleted the docs/create-asset-summaries branch November 29, 2021 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge kodiak automerge label
Development

Successfully merging this pull request may close these issues.

4 participants