Implement a filtered view for interactive-search.#3746
Conversation
1baf22a to
f3de52d
Compare
|
|
This is to replace the current interactive search for the current view, it has nothing to do with the real search/content search (control-F), and only applies to the current view (non-recursive). It's to aid selection not finding - you know the file probably exists. The current interactive search ('just start typing') only matches starting characters in a filename. #3714 aimed to make that match anywhere in a filename, which I felt is more of a hindrance than an improvement, since it can result in meaningless matches you need to navigate past to get to the file you wanted. |
0ee6b43 to
d193866
Compare
|
I wasn't aware of this file positioning function! Obviously I have never used it, and for me, the old version is sufficient. |
This would replace the current interactive search feature (typing to restrict selection to filenames beginning with the typed text), except for the desktop view. Instead, typing would show an entry as before, but now: - The view will actively filter out non-matching files. - Matches will by made and scored using the 'fzy' matching algorithm based on https://github.com/jhawthorn/fzy. - Matching characters will be highlighted (bold) within the filename in the resulting list. - Focus/navigation remains in the view so keyboard navigation can still be performed while the filter is active. - Deleting (backspace) all text from the filter hides the filter and restores the normal view. ref: linuxmint#3714, linuxmint#507
d193866 to
7c6c25b
Compare
|
merged: 11df68c |
|
Sorry, I only got around to testing this now. The functionality in generally works fine, thank you :) However, it does not really solve my original use case (neither does my proposed #3714): navigating a directory tree fast. I'm not sure whether I should open a separate issue for this or where to discuss this best, please let me know the best place to put this (since this closed MR is certainly not the correct place). Let's assume the following directory tree: What I currently have to do with this feature:
I'd like to get rid of having to hit 'arrow down' to select the directory, since this requires moving my hand to the arrow block on the keyboard and then back to the 'main area' (don't know how to describe it best). On my old file browser (spacefm), the first entry in the view is always selected by default (although it is a kind of 'soft selection', i.e. it is not completely highlighted, but only drawn with a border; I don't know what the difference is between those states though), so you can just hit enter directly whenever you enter a directory and you want to go into the first folder (or the first match after typing). Do you think it makes sense to add a similar behavior to nemo, so that you can:
|
|
Will some detailed documentation be available when the new filter option is released? |
|
I don't think that's necessary, there's not much to it. |
|
@mtwebster your commit looks great! Would it also make sense to always select the first file/directory by default (independent from this interactive search feature) so that hitting enter repeatedly allows to traverse a tree of |
This would replace the current interactive search feature (typing to restrict selection to filenames beginning with the typed text), except for the desktop view.
Instead, typing would show an entry as before, but now:
ref: #3714, #507